[Bug 38246] New: If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Bug ID: 38246 Summary: If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The checkout page searches for all return claims rather than only unresolved ones, so if an item being checked out has a return claim that was previously resolved, it will resolve it again and overwrite the previous resolution. Fortunately, any notes on the return claim are a separate functionality, so this will not erase the notes - it only updates the resolution timestamp and sets the resolution code (which is an authorized value and cannot contain free text). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173238&action=edit Bug 38246: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173239&action=edit Bug 38246: Perltidy QA tool failed because the previous patch added one line to a large block of code that was incorrectly indented. Fixed the indentation separately on this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173238|0 |1 is obsolete| | --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173248&action=edit Bug 38246: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173239|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173249&action=edit Bug 38246: Perltidy QA tool failed because the previous patch added one line to a large block of code that was incorrectly indented. Fixed the indentation separately on this patch. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173248|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173497&action=edit Bug 38246: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173249|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173498&action=edit Bug 38246: Perltidy QA tool failed because the previous patch added one line to a large block of code that was incorrectly indented. Fixed the indentation separately on this patch. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27753 Keywords| |rel_24_05_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 [Bug 27753] Automate resolution of return claim when checking in an item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't clean apply to 24.05.x, rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Lucas Gass (lukeg) from comment #8)
Doesn't clean apply to 24.05.x, rebase if needed.
I do reproduce the bug on 24.05, so yes, it should be backported. The first patch applies cleanly for me, and the second patch is just a big whitespace perltidy of existing code. I'll rebase the perltidy if it's necessary, but it would also be fine to just pick the first patch for backport if you're okay with that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 --- Comment #10 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175578&action=edit Bug 38246: [24.05.x] Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Reopened to add rebased patch for 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Emily, I have applied your third patch to 24.05.x and the test plan worked as expected. Could you please clarify for us, should we only be applying and backporting the third patch? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 --- Comment #13 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Alex Buckley from comment #12)
Hi Emily,
I have applied your third patch to 24.05.x and the test plan worked as expected.
Could you please clarify for us, should we only be applying and backporting the third patch?
Thanks, Alex
Yes, just backport the third patch - it's a rebased equivalent of the first two, since they didn't apply cleanly to 24.05.x. (I can't remember now why I decided to combine them into one patch when doing the rebase ^^") Thank you for backporting! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Emily Lamancusa (emlam) from comment #13)
(In reply to Alex Buckley from comment #12)
Hi Emily,
I have applied your third patch to 24.05.x and the test plan worked as expected.
Could you please clarify for us, should we only be applying and backporting the third patch?
Thanks, Alex
Yes, just backport the third patch - it's a rebased equivalent of the first two, since they didn't apply cleanly to 24.05.x. (I can't remember now why I decided to combine them into one patch when doing the rebase ^^") Thank you for backporting!
Hi Emily, Thank you for that! We probably won't be able to include it in the 24.05.07 release, due to time constraints - but it's on the list for backporting in the 24.05.08 release! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.08 released in| | Status|Pushed to main |Pushed to stable --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Nice work everyone! Pushed to 24.05.x for 24.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27753 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Big fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org