[Bug 11855] New: Coming up
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Bug ID: 11855 Summary: Coming up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25685&action=edit Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Coming up |Tiny code cleanup in | |members -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 25716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25716&action=edit [Signed-off] Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one. Followed test plan. No problems found. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25685|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26435&action=edit Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one. Followed test plan. No problems found. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26436&action=edit Bug 11855: remove unused template file members/search.tt seems not to be in use anymore. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25716|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #1)
Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now).
It looks useless, I submitted a followup to remove the template file. Galen, feel free not to push it if you have a doubt. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marcel and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org