[Bug 21027] New: Totals in statistics tab change when StatisticsFields is changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Bug ID: 21027 Summary: Totals in statistics tab change when StatisticsFields is changed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com As we understand it the totals in the last line of the statistics table in the patron account should be always the same, independent of the selection made in the StatisticsFields system preference. This is not the case. When "location" is removed, the total is less than with "location". I think this might have something to do with the group and empty values for some entries, but have not been able to find the problem yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Screenshots? Which values are different? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I retested it on master... not quite the same result as last time, but still something strange going on here. Hope the test plan works for you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76874&action=edit statistics tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76875&action=edit current checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For the screenshot the pref was set to location|itype|ccode. If location is removed, the number of checkouts shows as 2 (which is correct). Note: in the screenshot, the shelving location is also not shown? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9939 [Bug 9939] Add patron statistics to the OPAC (statistics tab in staff) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 88990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88990&action=edit Bug 21027; Fix checkout statistics if 1+ of the fields is not defined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Katrin, I think this patch fixes the problem you faced. I did not read a test plan as I have to admit I completely forgot about that code and not sure how the changes could be completely tested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #9 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- Created attachment 89008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89008&action=edit Screenshot_total_checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89008|Screenshot_total_checkouts |Screenshot_total_checkouts description| |without patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88990|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 91455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91455&action=edit Bug 21027; Fix checkout statistics if 1+ of the fields is not defined TEST - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) Apply the patch and try again Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91455|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91472&action=edit Bug 21027: Fix checkout statistics if 1+ of the fields is not defined TEST - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) Apply the patch and try again Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org