[Bug 16794] New: Revise layout for Admistration > Categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Bug ID: 16794 Summary: Revise layout for Admistration > Categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx@gmail.com Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Add a dropup button "Action" with Awesome icons for "Delete" and "Edit" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52674&action=edit Bug 16794: Revise layout for Admistration > Categories Add a dropup button "Action" with Awesome icons for "Delete" and "Edit" To test - Go to Administration -> Categories - Confirm that a button "Action" appear instead of links. - Also see the new icons for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 52676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52676&action=edit Bug 16794 - Revise layout for Admistration > Categories Add a dropup button "Action" with Awesome icons for "Delete" and "Edit" To test - Go to Administration -> Categories - Confirm that a button "Action" appear instead of links. - Also see the new icons for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I disagree that the links should be in a menu. I think in all other cases if there are only two actions we display actions as buttons. It's when there are three or more actions that we use a menu. I think one could argue that this page should be an exception because of the size of the table, but I would counter that perhaps we should trim down the number of columns displayed instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52674|0 |1 is obsolete| | Attachment #52676|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52697&action=edit Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Revise layout for |Revise layout for |Admistration > Categories |Admistration > Patron | |categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52697|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 52703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52703&action=edit Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Buttons appear now as requested in comment #3 (2 buttons, no action menu) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Comment on attachment 52703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52703 Bug 16794: Revise layout for Admistration > Patron categories Review of attachment 52703: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16794&attachment=52703) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt @@ +318,4 @@
[% END %] <th scope="col">Branches limitations</th> <th scope="col">Default privacy</th> + <th aria-label="Actions" style="width: 88.1px;" colspan="1" rowspan="1" class="sorting_disabled">Actions</th>
This looks like a copy and paste from DataTables-generated markup. I don't think we need anything more than '<th scope="col">Actions</th>' in the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52856&action=edit Bug 16794: (follow up) Change scope header to col only Fix copy and paste according with QA comment 6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #8 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Column Default privacy can't be sorted anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53002&action=edit Bug 16794: (follow up)Make column "Default privacy" could be sorted again Fix column "Default privacy" to be sorted again according with comment 8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52703|0 |1 is obsolete| | Attachment #52856|0 |1 is obsolete| | Attachment #53002|0 |1 is obsolete| | --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53003&action=edit Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53003|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 53048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53048&action=edit Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The 2 buttons should be grouped into the same column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #12)
The 2 buttons should be grouped into the same column.
Nevermind, I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53048|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53057&action=edit Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53058&action=edit Bug 16794: Group the 2 action buttons into the same column Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11,t hanks Hector! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org