[Bug 41361] New: Incorrect markup in category code confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Bug ID: 41361 Summary: Incorrect markup in category code confirmation modal Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32581 Bug 32581 introduced a new modal asking whether to update the patron's expiration date when changing the patron category. This modal uses older Bootstrap markup and doesn't work right. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32581 [Bug 32581] Update dateexpiry on categorycode change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190109&action=edit Bug 41361: Fix markup in category code confirmation modal This patch fixes the markup in the modal, introduced by Bug 32581, asking whether to update the patron's expiration date when changing the patron category. The markup needs to be updated to conform with Bootstrap 5. To test, apply the patch and go to Patrons. - Search for any patron and edit it. - Scroll down to the "Library management" section. - Change the category. - You should see a confirmation modal: "Confirm expiration date" - Test each of the controls to confirm that they work correctly: The "X" close button, the "Yes" and "No" buttons. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190109|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190135&action=edit Bug 41361: Fix markup in category code confirmation modal This patch fixes the markup in the modal, introduced by Bug 32581, asking whether to update the patron's expiration date when changing the patron category. The markup needs to be updated to conform with Bootstrap 5. To test, apply the patch and go to Patrons. - Search for any patron and edit it. - Scroll down to the "Library management" section. - Change the category. - You should see a confirmation modal: "Confirm expiration date" - Test each of the controls to confirm that they work correctly: The "X" close button, the "Yes" and "No" buttons. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Confirm release notes| |expiration date" dialog box | |that is shown when changing | |an individual patron's | |category: | |- The "No" option now | |works. | |- It is now formatted using | |our standard Bootstrap 5 | |styles. --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I changed the patron category for Mary Burton from Patron to Home Bound: 1.1 Browser pop-up with message: Change messaging preferences to default for this category? 1.2 Press OK 1.3 Dialog box/Modal appears (see screenshot 1) 1.4 Clicking the "No" option does nothing 1.5 The dialog box is not formatted correctly 2. Apply the patch and repeat the steps. 3. The "No" option now works. 4. The dialog box (see screenshot 2) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 190136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190136&action=edit Screenshot 1 - Before the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190137&action=edit Screenshot 2 - After the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190135|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 190200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190200&action=edit Bug 41361: Fix markup in category code confirmation modal This patch fixes the markup in the modal, introduced by Bug 32581, asking whether to update the patron's expiration date when changing the patron category. The markup needs to be updated to conform with Bootstrap 5. To test, apply the patch and go to Patrons. - Search for any patron and edit it. - Scroll down to the "Library management" section. - Change the category. - You should see a confirmation modal: "Confirm expiration date" - Test each of the controls to confirm that they work correctly: The "X" close button, the "Yes" and "No" buttons. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@openfifth.co.uk --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.01 |26.05.00,25.11.01,25.05.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to oldstable |Needs documenting --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Depends on 32581 which will not be backported, not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41361 --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Enhancement, not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org