[Bug 18774] New: Internal Server Error in Price.pm with big numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 Bug ID: 18774 Summary: Internal Server Error in Price.pm with big numbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org If users accidentally enter a big number e.g. in Home > Patrons > Manual invoice, Koha fails with an Internal Server Error in Price.pm To reproduce, enter a value of: 99999999999999 Plack error log says: Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/marc/koha/Koha/Number/Price.pm line 44. After that error, the detail page of the user where the invoice was applied can no longer be displayed, it produces the same Internal Server Error This is due to the fact that the big number is stored in table accountlines. Setting to major because normal users can not recover from this situation. To recover, you have to delete or update the records in table accountlines. The same error can be produced with a manual credit. The same error can occur in Administration > Patron Categories if the numbers in the database are too big, see http://irc.koha-community.org/koha/2017-06-09#i_1942793 ...but it can not be reproduced by entering a big number. Biggest number you can enter is: 99999999 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 64171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64171&action=edit Bug 18774: Add test to highlight problem with Internal Server Error in Price.pm Add a test for a big number to t/Number/Price.t Test will fail with: round() overflow. Try smaller precision or use Math::BigFloat at (...)/Koha/Number/Price.pm line 44. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64171|0 |1 is obsolete| | --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64188&action=edit Bug 18774: Add test for Price.pm Add a test for a big number to t/Number/Price.t Test will fail with: round() overflow. Try smaller precision or use Math::BigFloat at (...)/Koha/Number/Price.pm line 44. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Test failure occurs as described. This patch passes QA tools. Still in need of a patch for the problem itself but the patch works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15770 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17164 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11698 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12844 [Bug 12844] Introduce a centralized way to display prices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 --- Comment #3 from Marc Véron <veron@veron.ch> --- How to fix? - The problem occurs at other places as well (see related bugs). A first step could be to restrict amount users can enter, similar to the situation in Administration > Patron Categories, but theoretically fines and/or credits (and budgets etc., see Bug 11698) can sum up to a value that breaks display again. Where amounts are added, the fix could be to have a JavaScript validation against the sum, but it would be a workaround only, see following comment: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698#c2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 15770 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org