[Bug 16125] New: Regression: Can't add messages at checkout if no other messages are present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Bug ID: 16125 Summary: Regression: Can't add messages at checkout if no other messages are present Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/circulation.pl?borrowernumber=X OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Blocks: 15632 The "Add a new message" link is no longer visible on the checkout screen if no other messages are present. A sidebar on the right shows patron messages, if any, including hold waiting notices, outstanding fines, messages on their account, etc. Before Bug 15632 that sidebar displayed all the time, even if no messages were present. This wasn't ideal, but at least it created a space for the "Add new message" link to appear. Now that the sidebar is gone if there are no messages we need a place for the "Add new message" link. I think coming up with a new place for it is better than making it work like it did before. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 [Bug 15632] Move the messages related code to Koha::Patron::Messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49450&action=edit Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15632 Blocks|15632 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 [Bug 15632] Move the messages related code to Koha::Patron::Messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49450|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49454&action=edit Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49454|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49463&action=edit [PASSED QA] Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16125 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org