[Bug 11292] New: barcode scanner clicking 'save'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Bug ID: 11292 Summary: barcode scanner clicking 'save' Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When cataloging a bib record if you scan an ISBN barcode in the barcode scanner clicks the 'save' button before the cataloging is done. This did not happen in 3.10, but is happening again in 3.12. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 George Williams <georgew@latahlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |georgew@latahlibrary.org --- Comment #1 from George Williams <georgew@latahlibrary.org> --- I'm thinking that any time you send a carriage return Koha is triggering the default page action because it's not just scanning a barcode that causes the save. In Koha 3.12 a record is saved anytime you hit the "enter" key when the cursor is in any field in a cataloging record. George -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just tested 11563 for QA, but it doesn't fix this specific problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #3 from jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> --- I wrote a script and put in the the intranetusersjs field that removes the noEnterSubmit function from specific fields. This is now allowing us to scan barcodes without it try to save automatically because of the carriage return set in the scanners. //Remove noEnterSubmit from fields - JD $(document).ready(function(){ $("#userid").removeClass("noEnterSubmit"); $("#cardnumber").removeClass("noEnterSubmit"); $("#subfield952p637072").removeClass("noEnterSubmit"); }); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- (In reply to jdemuth@roseville.ca.us from comment #3)
I wrote a script and put in the the intranetusersjs field that removes the noEnterSubmit function from specific fields. This is now allowing us to scan barcodes without it try to save automatically because of the carriage return set in the scanners.
//Remove noEnterSubmit from fields - JD $(document).ready(function(){ $("#userid").removeClass("noEnterSubmit"); $("#cardnumber").removeClass("noEnterSubmit"); $("#subfield952p637072").removeClass("noEnterSubmit"); });
Thank you for the script but it is not working for me. In wich version of koha you tested it? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #5 from jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> --- Sorry, I forgot to include we just upgraded to 3.14.4. I did notice that it is not "saving" the page which it great, but it is losing focus. I think I know how to fix that and I will test tonight and If it works I will include the updated script. Jen -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28435&action=edit Bug 11292 - barcode scanner clicking 'save' When cataloging a bib record if you scan an ISBN barcode in the barcode scanner clicks the 'save' button before the cataloging is done. This did not happen in 3.10, but is happening again in 3.12. Test Plan: 1) Open the marc editor 2) Focus on a field, hit the enter key 3) Note the record tries to save 4) Focus on an indicator, hit the enter key 5) Note the record tries to save 6) Apply this patch 7) Repeat steps 2 and 4, note the record no longer tries to save upon carriage return -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Patch applied cleanly and worked as outlined. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28435|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28435|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 28518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28518&action=edit Bug 11292 - barcode scanner clicking 'save' When cataloging a bib record if you scan an ISBN barcode in the barcode scanner clicks the 'save' button before the cataloging is done. This did not happen in 3.10, but is happening again in 3.12. Test Plan: 1) Open the marc editor 2) Focus on a field, hit the enter key 3) Note the record tries to save 4) Focus on an indicator, hit the enter key 5) Note the record tries to save 6) Apply this patch 7) Repeat steps 2 and 4, note the record no longer tries to save upon carriage return Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Patch tested with a sandbox. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Shouldn't we add the noEnterSubmit class to the elements? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)
Shouldn't we add the noEnterSubmit class to the elements?
This can be pushed in its current state. Note that it is referring to cataloging.js instead of staff-global.js where a keypress is active on class noEnterSubmit. I agree that another report could bring these two closer (achieving more consistency..) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |gmcharlt@gmail.com --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to M. de Rooy from comment #11)
(In reply to Jonathan Druart from comment #10)
Shouldn't we add the noEnterSubmit class to the elements?
Or to the form itself. That would be a more minimal fix, and more consistent.
This can be pushed in its current state. Note that it is referring to cataloging.js instead of staff-global.js where a keypress is active on class noEnterSubmit.
Marcel, have you tested /all/ of the interfaces that this patch touches? By changing cataloging.js and matching on .input_marceditor, a bunch of forms are affected, not just the main cataloging editor: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt (and here accepting this patch means that there would be /two/ handlers trying to prevent form submission via the enter key) koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt Now, that isn't necessarily a problem -- as arguably none of these forms should be submittable using the enter key, but this patch is an example of one where the test plan does not account for all of the side effects.
I agree that another report could bring these two closer (achieving more consistency..)
Why wait? Why not insist on consistency now as opposed to adding inconsistency? This doesn't necessarily /require/ a counter-patch now, but I am setting back to 'signed off' pending confirmation that all of the forms that this patch affects have been tested, particularly the item editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Galen Charlton from comment #12)
Marcel, have you tested /all/ of the interfaces that this patch touches? By changing cataloging.js and matching on .input_marceditor, a bunch of forms are affected, not just the main cataloging editor:
I noticed that it impacts more than the editor (biblio/items); I additionally looked at the acquisition forms for that reason. (Hopefully, the one who signed off, did some testing too :) But for consistency, I certainly do not mind further improvements here. Especially if the author could amend or send a follow-up. But if not, there is no reason imo to block this patch for that reason. BTW I additionally checked now: authorities.pl, serials-edit.pl and batchMod.pl. No problems encountered. Back to Passed QA. Kyle: Could you please respond about your possibilities to amend/adjust in light of the above? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- I am more than willing to make adjustments if necessary. However, I'm not grokking what the inconsistency in this case is. Should be make noEnterSubmit apply to forms Koha-wide, and have a provision to allow it ( i.e. allowEnterSubmit )? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #14)
I am more than willing to make adjustments if necessary. However, I'm not grokking what the inconsistency in this case is. Should be make noEnterSubmit apply to forms Koha-wide, and have a provision to allow it ( i.e. allowEnterSubmit )?
To my understanding: the inconsistency is two ways to handle the same. You define a separate keyboard handler, but elsewhere the class name noEnterSubmit is picked up by a global keyboard handler (see staff-global.js). It would be more consistent to do the same in cataloging.js. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28863&action=edit Bug 11292 [QA Followup] - Use noEnterSubmit instead of new keypress handler Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11563 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11292 --- Comment #19 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org