[Bug 27724] New: Use lenient also in Elasticsearch authorities search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Bug ID: 27724 Summary: Use lenient also in Elasticsearch authorities search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type interger. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116991&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116996&action=edit Bug 27724: Add unit test Run t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116991|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116997&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116997|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 119062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119062&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Sorry, I missed the first patch during the signoff, I correct that in a second ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116996|0 |1 is obsolete| | --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 119066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119066&action=edit Bug 27724: Add unit test Run t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119062|0 |1 is obsolete| | --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 119067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119067&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119066|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121002&action=edit Bug 27724: Add unit test Run t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119067|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121003&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- As a step towards QA, here is another signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121002|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121041&action=edit Bug 27724: Add unit test Run t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121003|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121042&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Logically this makes sense to me.. works as described and includes expected tests.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | CC| |andrew@bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org