[Bug 6556] New: The popup menu in the Z39.50 search results doesn't point to the correct record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Bug #: 6556 Summary: The popup menu in the Z39.50 search results doesn't point to the correct record. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Created attachment 4565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4565 Corrects the popup menu links in the z3950 search results. In the results of a Z39.50 search, if a result is clicked, a small popup menu appears with the options "Preview MARC","Preview Card","Import","X". If we compare the URL of the "Preview Marc" menu option and the URL of the "MARC" link on the same line, we can see that the "importid" is not the same in the two URLs. The importid in the popup menu seems to always be the importid of the last item of the results list. Patch attached that corrects the problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|gmcharlt@gmail.com |fcapovilla@live.ca -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-07-06 11:50:09 UTC --- Do you have any idea why this bug does not come up in 3.3/3.5? The lines you move in the 3.2 template, are still in the same position too in master (in the tt template file). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-07-06 12:10:18 UTC --- Here is the corresponding change in master (Bug 6367): http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3b8c61d5dcd9... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-07-06 12:14:38 UTC --- (In reply to comment #2)
Here is the corresponding change in master (Bug 6367): http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3b8c61d5dcd9...
Thanks for responding. I looked at acqui template. So I understand now that the same change should still be applied there (just as in cataloguing) .. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-07-08 19:53:36 UTC --- Patch does not apply to either current HEAD nor 3.2.x branch. Is this a backport only, and if so, to which version? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Signed Off --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> 2011-07-22 07:50:02 UTC --- It applies fine for me on branch 3.2.x. git am -iu3 Patches/dl/0001-Corrects-the-popup-menu-links-in-the-z3950-search-re.patch Commit Body is: -------------------------- Corrects the popup menu links in the z3950 search results. The popup menu's options didn't link to the correct breedingid. -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Corrects the popup menu links in the z3950 search results. Using index info to reconstruct a base tree... <stdin>:16: trailing whitespace. <stdin>:39: trailing whitespace. warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tmpl And it works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 --- Comment #6 from Frédérick Capovilla <fcapovilla@live.ca> 2011-07-25 13:03:09 UTC --- Additionnal information : This patch was created on version 3.02.03.001 . Sorry for the inconvenience. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-31 23:57:31 UTC --- With 3.2.x ended, does this need to be reformatted for 3.4.x/master or is the bug not existent there? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #8 from Magnus Enger <magnus@enger.priv.no> 2011-08-04 06:40:58 UTC --- I just tested this with Cataloging > Z39.50 Search on current master, and the problem is still there. All the popups use the "importid" of the record at the bottom of the list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> 2011-08-11 18:55:11 UTC --- Magnus, it's working for me on master. See this video and watch the status bar showing the import id for each link: http://www.screencast.com/t/ZlUtyLemDJtb The links in each row match. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- This needs a full rewrite if it is still needed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this has been fixed a longer time ago, please reopen if I am mistaken. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org