[Bug 12361] New: Bootstrap theme is missing colors.css
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Bug ID: 12361 Summary: Bootstrap theme is missing colors.css Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. Sould we create the file in bootstrap theme or set the syspref empty by default ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I vote to set it empty by default. colors.css in the prog theme is an empty file, so it doesn't really do the prog theme any good to have opaccolorstylesheet filled automatically. The only theme which requires it is CCSR. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bootstrap theme is missing |No default value for |colors.css |opaccolorstylesheet syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 --- Comment #2 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 28669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28669&action=edit Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/admin/prefere | |nces.pl?tab=&op=search&sear | |chfield=opaccolorstylesheet -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28669|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 28692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28692&action=edit Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error Signed-off-by: David Cook <dcook@prosentient.com.au> Glad to see this one. That warning was annoying. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28692|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28699&action=edit Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org