[Bug 25583] New: When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Bug ID: 25583 Summary: When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When you add a 'claimed returned' to an item, but ClaimReturnedLostValue is not set, the "Claims" tab won't display and cause some confusion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 25518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- In master at least, you cannot click "claim returned" if the pref is not set. I am not sure this is (still) valid. Can you close or clarify? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just retested on master, this is what I see: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts - Click "Claim returned" - Modal opens - Make claim (submit) - The item is now "claimed returned" in the checkouts tab, but the claims tab is not showing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This is sort of at odds with bug 24767, in which we hid the claims tab if the value is not set. Katrin, your test plan sort of sneaks up on Claims, by using the Columns button to show the Return Claims column that would otherwise be hidden. Is the answer here to just not allow one to reveal the claims column at all when ClaimReturnedLostValue is not set? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113867&action=edit Bug 25583: Disable the "claim returned" button if the feature is disabled It's possible to display the "Return claims" column on the checkout list, even if the feature is disabled. We should disable the link and add an explanation. Test plan: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts => The button is disabled and a tooltip explains that the feature is disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14697 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25134 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113867|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113878&action=edit Bug 25583: Disable the "claim returned" button if the feature is disabled It's possible to display the "Return claims" column on the checkout list, even if the feature is disabled. We should disable the link and add an explanation. Test plan: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts => The button is disabled and a tooltip explains that the feature is disabled Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113878|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114108&action=edit Bug 25583: Disable the "claim returned" button if the feature is disabled It's possible to display the "Return claims" column on the checkout list, even if the feature is disabled. We should disable the link and add an explanation. Test plan: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts => The button is disabled and a tooltip explains that the feature is disabled Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) About the phrasing, should we say "Claim returned is disabled" or "Return claims are disabled"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114245&action=edit Bug 25583: (QA follow-up) Rephrase tooltip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Here is an optional follow-up to rephrase with "Return claims are disabled" Release manager can pick this phrasing or the original one. I did a poll on IRC and got only one participant so not sure which is best. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114245|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114276&action=edit Bug 25583: Improve wording -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- < kidclamp> yeah, the phrase is a little awkward either way but I think it makes sense < Joubu> what would be a less awkward phrase? * ashimema reads < kidclamp> 'Claim returned' has become a thing in libraries, I think that is what makes it awkward, that those two words now go together as a pair < kidclamp> "Claim an item was returned" 'Claim this issue was returned" - its shorthand for things like that < ashimema> I think without the patch is better personally.. < ashimema> as it matches the content of the later string < ashimema> 'Claim returned' and 'Claim returned is disabled' feel like they go together < ashimema> could even be 'This is disabled' < Joubu> "This feature is disabled"? < ashimema> that would work for me :) < kidclamp> "ClaimReturnedLostValue is not set, this feature is disabled" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org