[Bug 41144] New: Fix markup errors in self checkout and self checkin templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Bug ID: 41144 Summary: Fix markup errors in self checkout and self checkin templates Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 21266 The W3C HTML validator complains of a number of minor issues in the self checkout and self checkin templates which should be addressed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188665&action=edit Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing <fieldset>s (<legend> must be inside one) - Stray ending </div> - Missing <tr> The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - The only error you see should be one about a duplicate ID "langmenu" which is outside the scope of this patch. - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 [Bug 41113] Missing doc-head-close and cssinclude in sci-main.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188665|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190315&action=edit Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing <fieldset>s (<legend> must be inside one) - Stray ending </div> - Missing <tr> The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - The only error you see should be one about a duplicate ID "langmenu" which is outside the scope of this patch. - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <you@example.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hope I tested this correctly. Testing notes (using KTD and Firefox Developer EDition): 1. System preferences: - WebBasedSelfCheck: enabled by default in KTD - SelfCheckInModule: need to enable 2. URL for the self check-out module: 127.0.0.1:8080//cgi-bin/koha/sco/sco-main.pl - Only INFO messages after the patch (login page and after login) 3. URL for self check-in module: 127.0.0.1:8080/cgi-bin/koha/sci/sci-main.pl - Only INFO messages after patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190315|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 190320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190320&action=edit Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing <fieldset>s (<legend> must be inside one) - Stray ending </div> - Missing <tr> The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - The only error you see should be one about a duplicate ID "langmenu" which is outside the scope of this patch. - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 --- Comment #5 from David Nind <david@davidnind.com> --- My sign-off line was incorrect, so have updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- This is going to have some conflicts with bug 41645 I reckon but it's important to fix these. The self-checkin looks so busted right now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Hmm I'm pretty sure this is wrong. The <header> is supposed to be within the wrapper div... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 [Bug 41646] Self-checkin displaying too much whitespace due to incorrect HTML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
Hmm I'm pretty sure this is wrong. The <header> is supposed to be within the wrapper div...
Yeah looking at koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc I can see that the wrapper encapsulates the header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41647, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41645 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190320|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191715&action=edit Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing <fieldset>s (<legend> must be inside one) - Stray ending </div> - Missing <tr> The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. Unrelated: Minor markup changes to langmenu.inc in order to fix HTML validation errors. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191716&action=edit Bug 41144: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Failed QA --- Comment #11 from David Cook <dcook@prosentient.com.au> --- I think this latest patch has duplicate wrapper divs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Quick question: I thought we weren't doing separate tidy patches these days? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Bug 41144 depends on bug 41646, which changed state. Bug 41646 Summary: Self-checkin displaying too much whitespace due to incorrect HTML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Will put these fixes into Bug 21266 and Bug 41113 *** This bug has been marked as a duplicate of bug 21266 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21266 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41113 | Depends on|41646 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41113 [Bug 41113] Missing doc-head-close and cssinclude in sci-main.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 [Bug 41646] Self-checkin displaying too much whitespace due to incorrect HTML -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org