[Bug 39271] New: There are size attributes in the input tags.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Bug ID: 39271 Summary: There are size attributes in the input tags. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: nina.martinez@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, oleonard@myacpl.org Assistive technologies can substitute or extend the CSS to modify presentation, or ignore the CSS and interact directly with the structural encoding. Presentation attributes should not be used in tags, such as size in the input tag. https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nina.martinez@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 --- Comment #1 from nina <nina.martinez@biblibre.com> --- Created attachment 179125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179125&action=edit Bug 39271: Replace the size attributes of the input tags with styles in the CSS page. test plan : 1- Verify that there aren't size attributes in the input tags 2- Verify that the input design is coherent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] [OMNIBUS] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I'm not seeing where accessibility guidelines say that input "size" attributes are an accessibility problem. Could you point to some additional documentation? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 --- Comment #3 from nina <nina.martinez@biblibre.com> --- Here is some additional documentation on the RGAA. The RGAA is the French equivalent of the WCAG. Translation of the important information : https://accessibilite.numerique.gouv.fr/methode/criteres-et-tests/#10 10.1.2 In each web page, presentation attributes should not be present in the generated source code of the page. Methodology : 1 - Verify the absence of presentation attributes : align, alink, background, bgcolor, border, cellpadding, cellspacing, char, charoff, clear, color, compact, frameborder, hspace, link, marginheight, marginwidth, text, valign, vlink, vspace, size(exception of the element <select>), width (exception of the element <img>, <object>, <embed>, <canvas> and <svg>), height (exception of the element <img>, <object>, <embed>, <canvas> and <svg>) ; 2 - If this is the case, the test is validated. https://accessibilite.numerique.gouv.fr/methode/glossaire/#presentation-de-l... Information presentation. Visual rendering of content via a browser in graphical mode. The presentation concerns the style, the position and the dimension of HTML elements and their content. The presentation information should be done with CSS. The element basefont, big, blink, center, font, marquee, s, strike and tt) and the attributes (align, alink, background, bgcolor, border, cellpadding, cellspacing, char, charoff, clear, compact, color, frameborder, hspace, link, marginheight, marginwidth, text, valign, vlink, vspace) are prohibited. Notes : - The width and height attributes used on elements other than <img>, <object>, <embed>, <canvas> and <svg> are prohibited. - The size attribute used on elements other than <select> is also prohibited. - The <u> element is prohibited only if the document doctype does not correspond to HTML 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179125|0 |1 is obsolete| | --- Comment #4 from nina <nina.martinez@biblibre.com> --- Created attachment 179685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179685&action=edit Remove the input size attributes and replace it with css style -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 --- Comment #5 from nina <nina.martinez@biblibre.com> --- (In reply to nina from comment #4)
Created attachment 179685 [details] [review] Remove the input size attributes and replace it with css style
Test plan : 1- Verify that there are no size attributes in the input tags on the opac pages 2- Verify that the input design is still coherent 3- if that is the case, the test succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 --- Comment #6 from nina <nina.martinez@biblibre.com> --- (In reply to nina from comment #5)
(In reply to nina from comment #4)
Created attachment 179685 [details] [review] [review] Remove the input size attributes and replace it with css style
Test plan :
1- Verify that there are no size attributes in the input tags on the opac pages : 2- Verify that the input design is still coherent 3- if that is the case, the test succeeds
update Test plan : 1- Verify that there are no size attributes in the input tags on the opac pages and Verify that the input design is still coherent . Apply patch and restart_all . Click 'Log in to your account’ and click on log in without completing the authentication (opac-auth) . Click on “log in to your account” and “Forgot your password” (opac-password-recovery) (syspref : OpacResetPassword) . Log in (if you're not already logged in, if you already are, go to Your account) (opac-user) . Click 'Add to your lists' (opac-addbybiblionumber) . Click on 'Advanced search' (opac-advsearch) . Click on the 'Personal details' tab (opac-memberentry) . Click on the 'Change password' tab (opac-passwd) . Click 'Place recall' (opac-recall) (syspref : UseRecalls) . Click 'Request article' (opac-request-article) (syspref : ArticleRequests) . Make a search that will return several results . Click on a title to access the detailed record . Click 'Place hold' (opac-reserve) . Click 'Add to your cart' . Click 'Cart' at the top of the page . Click 'Send' (opac-sendbasketform) . Click on the list name . Click 'Send list' (opac-sendshelfform) . Click on ‘List’ and on ‘share’ present on a list (if you don’t have a list, create one) (syspref : OpacAllowSharingPrivateLists) (opac-shareshelf) . Click on the 'Purchase suggestions' tab (opac-suggestions) . Click on the 'Tags' tab (opac-tags) .Click on ‘ Subject cloud ’ (opac-tags_subject) (syspref : OpacCloud ) .Click on ‘ Create an account’ and create a new account (opac-registration-confirmation) (syspref : PatronSelfRegistration ) - opac-reset-password page 2- if that is the case, the test succeed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk --- Comment #7 from Andrew Auld <andrew.auld@openfifth.co.uk> --- As discussed, some more guidance is needed in the test plan on what attributes your patch actually fixes on each page where you have made a change. This will make it easier to identify and test that the changes have been successfully implemented by the patch, before and after applying it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 --- Comment #8 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 180420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180420&action=edit Bug 39271: Remove the input size attributes and replace it with css style Test plan : 1- Verify that there are no size attributes in the input tags on the opac pages and Verify that the input design is still coherent . Apply patch and restart_all . Click 'Log in to your account' and click on log in without completing the authentication (opac-auth) ( input tag label, 'Card number or username:' and 'Password:' ) . Click on 'log in to your account' and 'Forgot your password' (opac-password-recovery) (syspref : OpacResetPassword) (input tag name, 'Card number or username:' , 'Email:', 'New password' and 'Confirm new password:' ) .Click on 'Create an account' and create a new account (opac-registration-confirmation) (syspref : PatronSelfRegistration ) (input tag name, 'Card number or username:' and ' Password:' ) . Log in to your account . Click on the 'Personal details' tab (opac-memberentry) (input tag name, all the 'Street number:', 'Library card number:' and 'Date of birth', ') . Click on the 'Change password' tab (opac-passwd)(input tag name, 'Current password:', 'New password:' and 'Re-type new password:') . Click on 'Advanced search' (opac-advsearch)(input tag name, 'Publication date range:' ) . Make a search that will return results . Click on a title to access the detailed record . Click 'Place hold' and show more options (opac-reserve)(input tag name, 'Hold starts on date:' and 'Hold not needed after:' ) (syspref : AllowHoldDateInFuture and OPACAllowHoldDateInFuture) . Enable the UseRecalls system preference . Check out an item to Patron B. (create another Patron, search a record, go to staff interface and check out this item) . Log into the OPAC as Patron A (your account ) and search for the item. . Click 'Place recall' (opac-recall) (input tag name, 'Recall not needed after :' ) . Click on 'Request article' (opac-request-article) (syspref : ArticleRequests)(input tag name, 'Title:', 'Author:', 'Volume', 'Issue', 'Date', 'Pages', 'Chapters' and 'Notes' ) . Click on 'Add to your cart' . Click 'Add to your lists' (if you don't have a list, create one) (opac-addbybiblionumber)(input tag name, 'List name:' ) . Click on 'Lists' . Click on the list name . Click 'Send list' (opac-sendshelfform) (input tag name, 'Email address :' ) . Click on 'List', 'Your lists' and on 'share' (if you don't have a list, create one) (syspref : OpacAllowSharingPrivateLists) (opac-shareshelf) (input tag name, 'Email address :' ) . Click 'Cart' at the top of the page . Click 'Send' (opac-sendbasketform)(input tag name, 'Email address :' ) . Log in, if you're not already logged in and if you already are, go to Your account. After that go to 'Holds' section (if you don't have it, you have to search a record and click on 'place hold' ) (opac-user) (input tag name, 'Suspend until:' ) . Click on the 'Purchase suggestions' tab and 'New purchase suggestion' (syspref : suggestion )(opac-suggestions)(input tag name, 'Standard number (ISBN, ISSN or other):', 'Publication year:', 'Quantity:' and 'Search for:') . Click on the 'Tags' tab (opac-tags) (syspref : TagsEnabled ) (input tag name, 'Tag to show from other users: 'if you are logged in and 'Tags to show:' if you are not ) .Click on 'Subject cloud' (opac-tags_subject) (syspref : OpacCloud )(input tag name, 'up to' ) . opac-reset-password page (input tag name : 'Card number or username:', 'Current password:', 'New password:' and 'Confirm new password:') 2- if that is the case, the test succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39271 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There are size attributes |Remove size attribute from |in the input tags. |input tags in the OPAC -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org