[Bug 7188] New: case-insensitive grep of /mysql/ in C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7188 Bug #: 7188 Summary: case-insensitive grep of /mysql/ in C4::Context Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing AssignedTo: paul.poulain@biblibre.com ReportedBy: ian.walls@bywatersolutions.com QAContact: ian.walls@bywatersolutions.com Blocks: 6875 Porting this over from Paul's de-nesting C4 omnibus. C4::Context does an unnecessary case-insensitive grep on the database type, which is always 'mysql', unless someone manually edits the file. If they're doing that, they can expect buggy behaviour. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7188 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-06 11:22:59 UTC --- Created attachment 6244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6244 Bug 7188: C4::Context::db_scheme2dbi does case-insensitive grep Checking NYTProf in C4::Context, it appears that the /i flag is highly time-consumming As we don't support anything outside from mysql, returning directly mysql directly If in a future version PostgresSQL works, then we will have to update this sub. But if an ORM is introduced, this code will be removed completly anyway Testing note: Drops execution time of the line from 300ms to 20 microseconds (in my testing). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7188 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Passed QA --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-06 11:41:06 UTC --- This change reduces my installation from taking over 300ms to run this line, to 27 micro seconds. In my (limited) tests, I'm also finding that using /mysql/ returns in about the same amount of time as forcing the return of "mysql", within a few micro seconds. I don't know why, but figured I'd check. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7188 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |rel_3_8 Patch Status|Passed QA |Patch Pushed --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 14:52:41 UTC --- Patch pushed, please test. QMaint, it's up to you to decide if it can be applied onto 3.6. That would be worth the price, but there's a small risk of a problem. I don't think so though, so if I were you, I would apply it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7188 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7188 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org