https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|dateexpiry is missing in |dateexpiry and dateenrolled |the new modal for |are missing in the new |PatronSelfModificationBorro |modal for |werUnwantedField and others |BorrowerMandatoryField and | |others -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109300&action=edit Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and enrollmentdate are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Note: I changed the test plan in the commit message so that it says "dateenrolled and dateexpiry fields" instead of "dateenrolled and enrollmentdate" - it took me a while to figure out why I couldn't find "enrollmentdate". 8-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109686|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 109891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109891&action=edit Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and dateexpiry fields are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |dateenrolled and dateexpiry | |fields to the list of | |fields that can be selected | |in system preferences such | |as the | |BorrowerMandatoryField. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.