[Bug 11263] New: New 'locale' setting in subscriptions is not user friendly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Bug ID: 11263 Summary: New 'locale' setting in subscriptions is not user friendly Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Created attachment 22990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22990&action=edit screenshot showing locale selection The locale setting offers you a lot of cryptic choices according to the locales installed on your system. I can imagine that on some servers this list coudl grow even longer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7688 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this could turn into some kind of bigger problem if you have multiple instances from different countries on one server - the list is already very long with 2 languages (de* and en*). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23032&action=edit Bug 11263: locale setting is not user friendly The locales list for subscriptions should not be retrieve from the locales of the system. This patch retrieves the locales list from the Koha DB (in the same way as pref language and opaclanguages). Test plan: Edit a subscription (or a numbering pattern) and verify the list of languages is the same as languages available in Koha. Note: with this patch we loose the saeson translation, it is normal. See report linked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11265 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11262 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- It works... almost :( 710 [% IF l.language == locale.language %] But correct parameter is locale, not locale.language Changing that line to 710 [% IF l.language == locale %] and then works -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #3)
Changing that line to On line 710 of koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
If not, selected locale is not show, as in 11265. My test was on top of Bug 11265. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23032|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23128&action=edit Bug 11263: locale setting is not user friendly The locales list for subscriptions should not be retrieve from the locales of the system. This patch retrieves the locales list from the Koha DB (in the same way as pref language and opaclanguages). Test plan: Edit a subscription (or a numbering pattern) and verify the list of languages is the same as languages available in Koha. Note: with this patch we loose the saeson translation, it is normal. See report linked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23128|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 23131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23131&action=edit [SIGNED-OFF] Bug 11263: locale setting is not user friendly The locales list for subscriptions should not be retrieve from the locales of the system. This patch retrieves the locales list from the Koha DB (in the same way as pref language and opaclanguages). Test plan: Edit a subscription (or a numbering pattern) and verify the list of languages is the same as languages available in Koha. Note: with this patch we loose the saeson translation, it is normal. See report linked. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. New locale is retrieved from installed languages. I wonder if that list can be restricted to 'enabled' ones (parsing syspref language value). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
New locale is retrieved from installed languages. I wonder if that list can be restricted to 'enabled' ones (parsing syspref language value).
I think listing all installed languages is ok here. I can imagine a library not wanting to enable all the installed languages they want to use for serials. Apart from that I still think this could be a good candidate for an authorized value or a small table. Installing languages takes time, updates are often forgotten when you don't actually use them etc. And it would allow for entering "custom" seasons, like abbreviated versions, fall instead of autumn etc. If we had a pref/tool wherepeople can change it, this could also allow to have other custom patterns. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Katrin Fischer from comment #7)
Apart from that I still think this could be a good candidate for an authorized value or a small table. Installing languages takes time, updates are often forgotten when you don't actually use them etc. And it would allow for entering "custom" seasons, like abbreviated versions, fall instead of autumn etc. If we had a pref/tool wherepeople can change it, this could also allow to have other custom patterns.
Agreed -- I'm not a big fan of relying on system locales for getting month and day names (with the exception of considering their use for command-line utilities, since one would be logged into the server anyway), for several reasons: - it creates an extra point of breakage for the naive user - they can't be customized - since they don't cover seasons, currently only English and French are supported for season names. A mechanism that would allow the user to set season names would be trivial to extend to month and day names. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23131|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23472&action=edit [PASSED QA] Bug 11263: locale setting is not user friendly The locales list for subscriptions should not be retrieve from the locales of the system. This patch retrieves the locales list from the Koha DB (in the same way as pref language and opaclanguages). Test plan: Edit a subscription (or a numbering pattern) and verify the list of languages is the same as languages available in Koha. Note: with this patch we loose the saeson translation, it is normal. See report linked. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. New locale is retrieved from installed languages. I wonder if that list can be restricted to 'enabled' ones (parsing syspref language value). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and all tests. Works according to description. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a bit worried about the consequences of this change, requiring to install templates, that won't be used apart from creating the list. How could we improve this? Using code similar to how we generate the list of searchable languages in advanced search maybe? Using a system preference? Still going to pass this as this looks like an improvement to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #10)
I am a bit worried about the consequences of this change, requiring to install templates, that won't be used apart from creating the list. How could we improve this? Using code similar to how we generate the list of searchable languages in advanced search maybe? Using a system preference? Still going to pass this as this looks like an improvement to me.
Katrin, I used translated languages in order to avoid the long list. But maybe you are right. I am submitting a new followup for getting all languages (as the adv search). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23478&action=edit Bug 11263: Use all languages instead of translated only. This patch produces the same dropdown list as the one in the adv search. With this way, it won't be necessary to install additional templates to fill the locale list. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Bug 11263 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11263 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org