[Bug 30023] New: Add Koha::Old::Checkout->anonymize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Bug ID: 30023 Summary: Add Koha::Old::Checkout->anonymize Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Not sure why, but I forgot to add this method earlier on the bug tree. Needed for consistency and completion of the refactoring. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30007 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130161&action=edit Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130162&action=edit Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130161|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 130178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130178&action=edit Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130162|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 130179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130179&action=edit Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130178|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130277&action=edit Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130179|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130278&action=edit Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as designed and clarifies the code. Tested, and QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Bug 30023 depends on bug 30007, which changed state. Bug 30007 Summary: Make ->anonymize methods throw an exception if AnonymousPatron is not set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org