https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50251&action=edit Bug 16267: Making circ and fines rules actions buttons To test: 1) Go to Admin -> Circulation and fines rules 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16268 [Bug 16268] Add confirm message when deleting circ and fines rules -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Works fine, but sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL forbidden pattern: tab char (line 256) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50252|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50299&action=edit Bug 16267: Making circ and fines rules actions buttons EDIT: Comment 3 To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50304|0 |1 is obsolete| | Assignee|aleishaamohia@hotmail.com |arslanone@gmail.com --- Comment #7 from Arslan Farooq <arslanone@gmail.com> --- Created attachment 50306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50306&action=edit Making circ and fines rules actions buttons These steps worked: -------------- To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser -------------- And QA tools passed: -------------- Processing files after patches |========================>| 1 / 1 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template -------------- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50306|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50320&action=edit Bug 16267: Making circ and fines rules actions buttons EDIT: Comment 3 To test: 1) Go to Admin -> Circulation and fines rules 2) Fines rules a) Confirm that buttons Edit, Delete, Save, and Clear all show as font awesome buttons and work as expected 2) Default checkout, hold and return policy a) Confirm that column heading is now Actions b) Confirm that actions Save and Unset show as font awesome buttons and work as expected 3) Checkout limit by patron category AND holds policy by item type a) Confirm that buttons Add and Delete show as font awesome buttons and work as expected (you may need to add a rule to see the Delete button) 4) Confirm that none of the buttons wrap on a narrower browser Sponsored-by: Catalyst IT Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16267 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, should be in the May 2016 release! Tak Aleisha! -- You are receiving this mail because: You are watching all bug changes.