[Bug 35560] New: Use the REST API for holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Bug ID: 35560 Summary: Use the REST API for holds history Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Blocks: 34832 On members/holdshistory.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34832 [Bug 34832] [OMNIBUS] API all the Tables! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Would it be conceivable to have 2 (UI) tables, one for current holds and one for old ones? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Katrin, Nick, do you have opinions on this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- I like this one, we currently have a need for a deleted holds api (so outside systems can send emails related to cancellations) and this maes sense once we have that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think separating into current and old makes sense from a usability point of view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353 [Bug 35353] Add API endpoint to fetch patron's previous holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 [Bug 35610] Missing FK on old_reserves.branchcode? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160100&action=edit Bug 35560: [POC] Make the holds list use the REST API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160101&action=edit Bug 35560: DBIC specific -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am willing to continue the work here (during 24.05 cycle) if there is commitment from one tester and one QA member. Known problems: 0. Fix bug 35353 first 1. Both tables are using the same table settings (could be fixed on a separate bug, not considering blocker) 2. Missing tests 3. Not filtering on status 4. UI needs improvement (at least header missing on top of each table) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #9 from Didier Gautheron <didier.gautheron@biblibre.com> --- I'm in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 35353 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Bug 35560 depends on bug 35353, which changed state. Bug 35353 Summary: Add API endpoint to fetch patron's previous holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I do prefer these API's being added in their own bug personally.. that way they get clear visability in the release notes and are simple to QA directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #8)
I'm in.
And my axe! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #1)
Would it be conceivable to have 2 (UI) tables, one for current holds and one for old ones?
That seems reasonable to me. Just have a couple tables "Current holds" and "Historical holds" or some such wording. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #1)
Would it be conceivable to have 2 (UI) tables, one for current holds and one for old ones?
Go ahead! I meant to do that exact same thing many times but failed to have the time! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36084 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36084 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Bug 35560 depends on bug 35353, which changed state. Bug 35353 Summary: Add API endpoint to fetch patron's previous holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35610 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 [Bug 35610] Missing FK on old_reserves.branchcode? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160100|0 |1 is obsolete| | Attachment #160101|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163831&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163832&action=edit Bug 35560: Add filter on status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #7)
I am willing to continue the work here (during 24.05 cycle) if there is commitment from one tester and one QA member.
Known problems: 0. Fix bug 35353 first
Done.
1. Both tables are using the same table settings (could be fixed on a separate bug, not considering blocker)
Decided to have this on its own bug.
2. Missing tests
Done.
3. Not filtering on status
Done.
4. UI needs improvement (at least header missing on top of each table)
Looks good enough for now for me. Let me know if you have suggestions. Ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164093&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- This works well for me except with title sorting. The "anti-the" sorting type doesn't seem to be taken into account even though the markup looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #19)
This works well for me except with title sorting. The "anti-the" sorting type doesn't seem to be taken into account even though the markup looks correct.
That's is something global, we need to fix it at the REST API level (no idea how!). It should be fixed separately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36633 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Opened bug 36633. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #20)
That's is something global
Does that mean we can't use any custom sorting plugins? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163831|0 |1 is obsolete| | --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165231&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163832|0 |1 is obsolete| | --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165232&action=edit Bug 35560: Add filter on status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164093|0 |1 is obsolete| | --- Comment #25 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165233&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- Works well and looks good, besides the already noted title sorting. I am adding my sign-off here but leaving at NSO for more testers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #22)
(In reply to Jonathan Druart from comment #20)
That's is something global
Does that mean we can't use any custom sorting plugins?
string-sort should not be needed dates are sorted correctly already______ nsb/nse: I don't know how behaves the dbms callnumber: should work without additional trick, but needs to be confirmed Am I missing other ones? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Bug 35560 depends on bug 35353, which changed state. Bug 35353 Summary: Add API endpoint to fetch patron's previous holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #28 from David Nind <david@davidnind.com> --- Not unexpectedly, the patches no longer apply... git bz apply 35560 Bug 35560 - Use the REST API for holds history 165231 - Bug 35560: Use the REST API for holds 165232 - Bug 35560: Add filter on status 165233 - Bug 35560: (follow-up) Add in-page links to jump between tables Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35560: Use the REST API for holds Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 35560: Use the REST API for holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165231|0 |1 is obsolete| | Attachment #165232|0 |1 is obsolete| | Attachment #165233|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177161&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177162&action=edit Bug 35560: Add filter on status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177163&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177161|0 |1 is obsolete| | --- Comment #32 from David Nind <david@davidnind.com> --- Created attachment 177200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177200&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177162|0 |1 is obsolete| | --- Comment #33 from David Nind <david@davidnind.com> --- Created attachment 177201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177201&action=edit Bug 35560: Add filter on status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177163|0 |1 is obsolete| | --- Comment #34 from David Nind <david@davidnind.com> --- Created attachment 177202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177202&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to a release notes| |patron's hold history | |section in the staff | |interface: | |- Separates the | |holds history into two | |tables: "Current holds" and | |"Past holds" | |- Adds filters | |for each table, such as | |Show all, Pending, Waiting, | |Fulfilled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #35 from David Nind <david@davidnind.com> --- Created attachment 177203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177203&action=edit Screenshots - Patron holds table before and after the patches I've signed off, however I find the page much more "busy" now. I've attached a PDF with before and after screenshots. I don't have any suggestions right at the moment, but maybe we could ask Owen to have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to a |This enhancement to a release notes|patron's hold history |patron's hold history |section in the staff |section in the staff |interface: |interface: |- Separates the |- Uses the REST |holds history into two |API to generate the holds |tables: "Current holds" and |history page. |"Past holds" |- Separates |- Adds filters |the holds history into two |for each table, such as |tables: "Current holds" and |Show all, Pending, Waiting, |"Past holds". |Fulfilled |- Adds | |filters for each table, | |such as Show all, Pending, | |Waiting, Fulfilled. CC| |oleonard@myacpl.org --- Comment #36 from David Nind <david@davidnind.com> --- Adding Owen, in case he would like to provide some feedback on the change to the patron holds history page in the staff interface. I've attached a PDF with before and after screenshots. In my view it is now a bit more "busy", but I don't have any ideas right now on how to improve it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38939 [Bug 38939] Add reservenote to members/holdshistory.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177200|0 |1 is obsolete| | --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177792&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177201|0 |1 is obsolete| | --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177793&action=edit Bug 35560: Add filter on status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177202|0 |1 is obsolete| | --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177794&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177792|0 |1 is obsolete| | Attachment #177793|0 |1 is obsolete| | Attachment #177794|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 178897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178897&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 178898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178898&action=edit Bug 35560: Add filter on status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 178899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178899&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178897|0 |1 is obsolete| | Attachment #178898|0 |1 is obsolete| | Attachment #178899|0 |1 is obsolete| | --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178910&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178911&action=edit Bug 35560: Add filter on status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178912&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178913&action=edit Bug 35560: (follow-up) Changes to classes and ids; BS5 follow-ups This follow-up changes the "selected" class to "select_hold_status" to avoid possible future collisions with other CSS. IDs are added to the checkbox containers because I can already tell that some libraries will want to hide the "Processing" checkbox which is only relevant to some setups. The patch also makes a couple corrections to "alerts" to update them with BS5 classes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #47 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Since we now split in two tables, does it still make sense to fetch and display empty cancellation date in hold history ? Also if we have change to "past holds", we also should change "This patron has no historical holds." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #48 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #47)
Since we now split in two tables, does it still make sense to fetch and display empty cancellation date in hold history ?
Maybe, but it would be nice to have it pushed as it, then we iterate later. It has been waiting for a long time already. Now the 2 tables are identical, and so it's not trivial (neither impossible) to fix that. What do you think? I can work on that as soon as it's pushed.
Also if we have change to "past holds", we also should change "This patron has no historical holds."
Done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179552&action=edit Bug 35560: historical => past -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178910|0 |1 is obsolete| | --- Comment #50 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179573&action=edit Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178911|0 |1 is obsolete| | --- Comment #51 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179574&action=edit Bug 35560: Add filter on status Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178912|0 |1 is obsolete| | --- Comment #52 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179575&action=edit Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178913|0 |1 is obsolete| | --- Comment #53 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179576&action=edit Bug 35560: (follow-up) Changes to classes and ids; BS5 follow-ups This follow-up changes the "selected" class to "select_hold_status" to avoid possible future collisions with other CSS. IDs are added to the checkbox containers because I can already tell that some libraries will want to hide the "Processing" checkbox which is only relevant to some setups. The patch also makes a couple corrections to "alerts" to update them with BS5 classes. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179552|0 |1 is obsolete| | --- Comment #54 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179577&action=edit Bug 35560: historical => past Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I would like to see 2 tabs instead of tables on top of each other, as that might mean a lot of scrolling and a "messier" page. Tabs would also follow an existing interface pattern. What do you think? (I can file a bug later) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #57 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #55)
I would like to see 2 tabs instead of tables on top of each other, as that might mean a lot of scrolling and a "messier" page. Tabs would also follow an existing interface pattern. What do you think? (I can file a bug later)
I personally don't like tab, but I guess we need to wait for feedback from librarians? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #57)
(In reply to Katrin Fischer from comment #55)
I would like to see 2 tabs instead of tables on top of each other, as that might mean a lot of scrolling and a "messier" page. Tabs would also follow an existing interface pattern. What do you think? (I can file a bug later)
I personally don't like tab, but I guess we need to wait for feedback from librarians?
Yes, I was leaving the comment in hope to get some opinions :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 --- Comment #59 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40321 [Bug 40321] DataTables search ( dt-search ) does not work on holds history page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40530 [Bug 40530] Show hold cancellation reason in patron holds history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40543 [Bug 40543] pickup_library.branchname embed wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41451 [Bug 41451] Hold history search fails when itemtype column present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #60 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org