[Bug 11185] New: check-url-quick.pl fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Bug ID: 11185 Summary: check-url-quick.pl fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: frederic@tamil.fr QA Contact: testopia@bugs.koha-community.org When running check-url-quick.pl, it fails due to AnyEvent::HTTP module bad loading. It comes from this commit: f88f11b4f805a70c9748bc3676cb1ce086db2ce8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |frederic@tamil.fr --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 22666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22666&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The commit in question: Bug 7963 follow-up: die nicely if AnyEvent libraries not installed Does this mean that the follow-up on 7963 was wrong, and no follow-up was needed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> ---
Does this mean that the follow-up on 7963 was wrong, and no follow-up was needed?
The follow-up was wrong. If the optional dependency AnyEvent::HTTP isn't installed, a Perl error is displayed in any case. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22666|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22942&action=edit [SIGNED-OFF] Bug 11185 check-url-quick.pl fails Revert commit f88f11b4f805a70c9748bc3676cb1ce086db2ce8 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before this patch, check-url-quick.pl fails with an error. After the patch it runs correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Frédéric, Could you explain the goal of this patch please? I understand what it does, but not why it is useful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> ---
Could you explain the goal of this patch please? I understand what it does, but not why it is useful.
Not sure to understand you. If AnyEvent and AnyEvent::HTTP module are installed, the script execution fails. Long explanation: require AnyEvent::HTTP <> use AnyEvent::HTTP => the last exports http_request subroutine not the first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Ok, I did not see the call to http_request. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22942|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22955&action=edit Bug 11185 check-url-quick.pl fails Revert commit f88f11b4f805a70c9748bc3676cb1ce086db2ce8 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before this patch, check-url-quick.pl fails with an error. After the patch it runs correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master and 3.14.x. Thanks, Frédéric! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Frédéric! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org