[Bug 20484] New: Can access /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl without the elasticsearch preference on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Bug ID: 20484 Summary: Can access /cgi-bin/koha/admin/searchengine/elasticsearch/mapping s.pl without the elasticsearch preference on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Not a big deal, but one can access /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl without the Elasticsearch Search engine preference enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- I think this is actually a feature. We should rename the page to 'Elasticsearch search configuartion' and have a note that it only applies to ES. This would allow users to tweak the ES settings before switching to Elasticsearch as their engine -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 102549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102549&action=edit Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102549|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102566&action=edit Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- You might want to take into account that not all modules have been installed when not using Elastic?? Could not compile /usr/share/koha/admin/searchengine/elasticsearch/mappings.pl: Can't locate Catmandu/Importer/MARC.pm in @INC (you may need to install the Catmandu::Importer::MARC module) (@INC contains: /usr/share/koha /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/master/plugins) at /usr/share/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 28. BEGIN failed--compilation aborted at /usr/share/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 28. Compilation failed in require at /usr/share/koha/admin/searchengine/elasticsearch/mappings.pl line 27. BEGIN failed--compilation aborted at /usr/share/koha/admin/searchengine/elasticsearch/mappings.pl line 27. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can access |Always show Elasticsearch |/cgi-bin/koha/admin/searche |configuration page when |ngine/elasticsearch/mapping |permission is set |s.pl without the | |elasticsearch preference on | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102566|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103195&action=edit Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, missed Marcel's comment#4 - I will leave the status for now. Search engine configuration (Elasticsearch) is a bit long, wonder if we could discuss: Elasticsearch configuration as a title (next iteration, different bug). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. I missed comment 4 too :(. I can either revert or preferably we could have a followup that adds a method to check if the required dependencies are installed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103362&action=edit Bug 20484: Implement blocking_errors for ES config page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org