[Bug 24530] New: Show a number in title notes just as in the other tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Bug ID: 24530 Summary: Show a number in title notes just as in the other tabs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Although we do not show an empty title notes tab [see bug 10349], the number of notes might still be interesting just as we do for other tabs on the detail page like holdings, subscriptions, comments, etc. Intuitively, you are also inclined to think that there are no notes when you see a number after holdings and no number after descriptions etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just wondering about this line in the opac-detail template: [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] Where do we fill notes? Cant find that at first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 98084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98084&action=edit Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show a number in title |Show a number in title |notes just as in the other |notes just as in the other |tabs |tabs of opac detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98084|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 98356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98356&action=edit Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I have no particular view on whether to display the number of title notes or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #3)
Signed-off-by: David Nind <david@davidnind.com>
Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have some worries about this one: - Changes only OPAC, not staff - Might show a false 0 in some context: [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] <li id="tab_descriptions"> <a href="#descriptions">Title notes ( [% MARCNOTES.size %] )</a></li> If there are notes and/or Syndetics content, but no MARCNOTES, the tab will display 0, looking 'empty' to the patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the nicest way might be to include the Syndetics and note content in the number. If we can't tell for syndetics, maybe we could do something like: 1+ 5 5xx displaying + Syndetics content available = 5+ ? Or only show the number if Syndetics is not active. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #1)
Just wondering about this line in the opac-detail template:
[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
Where do we fill notes? Cant find that at first.
notes is coming from biblio.notes; but still cant find the place where it is passed into the template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #7)
I think the nicest way might be to include the Syndetics and note content in the number. If we can't tell for syndetics, maybe we could do something like: 1+
5 5xx displaying + Syndetics content available = 5+ ?
Or only show the number if Syndetics is not active.
If there is a Syndetics summary, I will add +1. It is a html blob. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 98635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98635&action=edit Bug 24530: (QA follow-up) Include Syndetics in notes count Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested by enabling the prefs and passing contents to the template var. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #6) Thanks for QAing.
- Changes only OPAC, not staff
Will open a new report for that.
- Might show a false 0 in some context:
[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] <li id="tab_descriptions"> <a href="#descriptions">Title notes ( [% MARCNOTES.size %] )</a></li>
If there are notes and/or Syndetics content, but no MARCNOTES, the tab will display 0, looking 'empty' to the patrons.
Good point. Adjusted in follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24617 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617 [Bug 24617] Add title notes count in staff detail (following 24530) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98356|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98992&action=edit Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98635|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98993&action=edit Bug 24530: (QA follow-up) Include Syndetics in notes count Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested by enabling the prefs and passing contents to the template var. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hope to see a patch for bug 24617 soon too :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #12)
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx David and Katrin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Jenkins is complaining about a missing filter: xt/find-missing-filters.t, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt line 573 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 99091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99091&action=edit Bug 24530: (QA follow-up) Add missing filter Jenkins is complaining about a missing filter: xt/find-missing-filters.t, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt line 573 The variable is just filled in the template but lets make Jenkins happy. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Followup pushed, thanks Marcel.. you beat me to it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com --- Comment #20 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show a number in title |Show the number of title |notes just as in the other |notes in the tab label on |tabs of opac detail page |the OPAC detail page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org