[Bug 22511] New: Koha::Account::Line->void is not limited to 'payments'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Bug ID: 22511 Summary: Koha::Account::Line->void is not limited to 'payments' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- The `void` routine in Koha::Account::Lines does restrict one to only being able to void a 'credit' accountline, however it does not distinguish between accounttypes. We do however, change the accounttype as part of the void routine to VOID and as such we may be loosing data, and thus audit trail, here. Credits can take the form of 'Payment', 'Writeoff', 'Lost Item Return', 'Fine Forgiven', 'Forgiven' and finally 'Credit'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 [Bug 18790] Add ability to void payments -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Actually.. we should be able to get to this original data via the offsets, walking backwards to find the first 'creation' offset... we don't however do that as yet and as such always display "Payment, voided" to the borrower for all such transactions.. this could be confusing to the end user? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- I actually consider this a feature. It's always possible that something like a writeoff was done accidentally and needs to be voided. The rest of the credit types could be argued, but I don't since great utility in preventing them from being voided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't think I gave this a good title.. I'll change it. I didn't really mean that's it's a bad thing that one can void all the different types of credit, but more that it's a bad thing that you loose the information as to what type of credit you have voided. In my opinion 'void' is a valid 'state' of any credit (and for that matter, I don't see why one shouldn't be able to void a debit too). See bug 22512 for more explanation, I may mark this bug as a duplicate at some point, or use to to encapsulate the corresponding work for the void part of adding states. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #3)
I don't think I gave this a good title.. I'll change it.
I didn't really mean that's it's a bad thing that one can void all the different types of credit, but more that it's a bad thing that you loose the information as to what type of credit you have voided.
In my opinion 'void' is a valid 'state' of any credit (and for that matter, I don't see why one shouldn't be able to void a debit too).
See bug 22512 for more explanation, I may mark this bug as a duplicate at some point, or use to to encapsulate the corresponding work for the void part of adding states.
Yes, I agree completely. It would make more sense to have a 'voided' column, or a 'status' column that could have the state 'voided'. Are there other states we should consider for payments? A 'state' column could be re-used for 22512 which cuts now on the number of additional columns needed. What do you think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Account::Line->void |Koha::Account::Line->void |is not limited to |loses the original type of |'payments' |the credit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86674&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86675&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not also wondering about the logic of updating both 'amount' and 'amountoutstanding' here.. shouldn't we perhaps keep the 'amount' as the original value so one can see not only 'What' was voided but also 'How much'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #7)
I'm not also wondering about the logic of updating both 'amount' and 'amountoutstanding' here.. shouldn't we perhaps keep the 'amount' as the original value so one can see not only 'What' was voided but also 'How much'.
The logic behind the current behavior is to avoid the need to specifically remove VOIDs from reports when summing amounts. That data should be available the account offsets table. That being said, I'm not opposed to a change in this behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- This needs a bit of UI logic so new voided payments and old VOID types look the same in the UI. In addition, it would make sends to update accoulines with an accounttype of VOID to also have a status of VOID. Since future voided payments will retain the original accountype, it would be reasonable for Koha to show the original account type *and* show that it was voided. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Totally agree.. I wasn't fully ready for testing yet.. my bad for setting it to NSO.. I meant to leave it as NEW until I'd done more here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #10)
Totally agree.. I wasn't fully ready for testing yet.. my bad for setting it to NSO.. I meant to leave it as NEW until I'd done more here.
NP! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86675|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86903&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86674|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86904&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86905&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86903|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86915&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86904|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86916&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86905|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86917&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86915|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87088&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86916|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87089&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86917|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87090&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87091&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87088|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87221&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87089|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87222&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87090|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87223&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87091|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87224&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87221|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87632&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87222|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87633&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87223|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87634&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87224|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87635&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Freshly re-based and ready for SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87632|0 |1 is obsolete| | Attachment #87633|0 |1 is obsolete| | Attachment #87634|0 |1 is obsolete| | Attachment #87635|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87650&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87650|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87651&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87652&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87653&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87654&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87704&action=edit Bug 22511: (follow-up) Add DB Update This update takes old VOID accountlines and attempts to restore the original accounttypes using the offsets and set the status to 'VOID' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87704|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87706&action=edit Bug 22511: (follow-up) Add DB Update This update takes old VOID accountlines and attempts to restore the original accounttypes using the offsets and set the status to 'VOID' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87651|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87796&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87652|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87797&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87653|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87798&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87654|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87799&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87706|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87800&action=edit Bug 22511: (follow-up) Add DB Update This update takes old VOID accountlines and attempts to restore the original accounttypes using the offsets and set the status to 'VOID' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Freshly rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87796|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87869&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87797|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87870&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87798|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87871&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87799|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87872&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87800|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87873&action=edit Bug 22511: (follow-up) Add DB Update This update takes old VOID accountlines and attempts to restore the original accounttypes using the offsets and set the status to 'VOID' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased again.. things are moving fast here at the moment :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87869|0 |1 is obsolete| | Attachment #87870|0 |1 is obsolete| | Attachment #87871|0 |1 is obsolete| | Attachment #87872|0 |1 is obsolete| | Attachment #87873|0 |1 is obsolete| | --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88707&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #51 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88708&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88709&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88710&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #54 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88711&action=edit Bug 22511: (follow-up) Add DB Update This update takes old VOID accountlines and attempts to restore the original accounttypes using the offsets and set the status to 'VOID' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88712&action=edit Bug 22511: (QA follow-up) Fix update database Test plan: Run db update (and have some voided accountlines) --> without patch it fails with error message similar to: Can't use string ("Payment") as a HASH ref while "strict refs" in use at (eval 1393) line 19. --> with patch it runs as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88713&action=edit Bug 22511: (QA follow-up) Refactor status description in templates Test plan: Before this patch, some accounttypes does not show status (for example voided payment) After this patch, the status is always generated - defaults to empty string This behaviour should be same in intranet and opac In OPAC templates there was even bug (used variable account instead of ACCOUNt_LINE), so the status was not shown at all Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Martin, it would be nice if you could sign-off my follow-ups ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88712|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88714&action=edit Bug 22511: (QA follow-up) Fix update database Test plan: Run db update (and have some voided accountlines) --> without patch it fails with error message similar to: Can't use string ("Payment") as a HASH ref while "strict refs" in use at (eval 1393) line 19. --> with patch it runs as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88713|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88715&action=edit Bug 22511: (QA follow-up) Refactor status description in templates Test plan: Before this patch, some accounttypes does not show status (for example voided payment) After this patch, the status is always generated - defaults to empty string This behaviour should be same in intranet and opac In OPAC templates there was even bug (used variable account instead of ACCOUNt_LINE), so the status was not shown at all Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the followups, nice bit of tidying and makes great sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #61 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Martin Renvoize from comment #59)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88748&action=edit Bug 22511: Fix type role->roll -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #62)
Created attachment 88748 [details] [review] Bug 22511: Fix type role->roll
Will fix List item->Lost item in the DB update on pushing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #64 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Nick Clemens from comment #63)
(In reply to Nick Clemens from comment #62)
Created attachment 88748 [details] [review] [review] Bug 22511: Fix type role->roll
Will fix List item->Lost item in the DB update on pushing
Silly me, I oversee it... thanks Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #65 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Bug 22511 depends on bug 22564, which changed state. Bug 22564 Summary: accounttype 'Rep' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org