[Bug 17216] New: Add a new table to store authorized value categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Bug ID: 17216 Summary: Add a new table to store authorized value categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Blocks: 15799 The way we manage authorized values is not consistent: Some are present in the DB, others are not (see bug 15799 comment 4 for more details). Worse, most of the time the FK does not exist (and datatype is not consistent: varchar 32 vs 20, 16,...). To help cleaning up this area, a new table to store authorized value categories would be helpful. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54979&action=edit Bug 17216: Add Koha::AuthorisedValueCategory|ies classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54980&action=edit Bug 17216: Add new table authorised_value_categories and populate it This patch set adds a new table authorised_value_categories to store authori(s|z)ed value categories into a separate table. The problematic is explained on bug 15799 comment 4: We need FK to the AV categories but some may not have authorized values yet. What does this patch set: - Add a new authorised_value_categories table - Populate it with known categories - Update FK items_search_fields.authorised_values_category - Create a new FK marc_subfield_structure.authorised_value (FIXME should be authorised_value_categories instead) They are some problems this patch set do not take into account: - The .sql installer files won't insert correctly (will have to be updated when this patch set will be ready to be pushed) - All the categories (even the ones without authorized values defined) are listed when you edit frameworks (marc_subfield_structure.pl) - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". Test plan: 0/ Execute the DB entry to create and populate the new table and set the FK 1/ Create a new AV category from the admin module (admin/authorised_values.pl) 2/ Add/edit subfield linked to a AV category (admin/marc_subfield_structure.pl) 3/ You won't be allowed to add AV for branches, itemtypes or cn_source. They are used internally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54981&action=edit Bug 17216: Add some other AV categories Found in installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54982&action=edit Bug 17216: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54983&action=edit Bug 17216: Update the admin interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54984&action=edit Bug 17216: Add FK on mss.authorised_value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54985&action=edit Bug 17216: Use Koha::AVC from mss.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54979|0 |1 is obsolete| | Attachment #54980|0 |1 is obsolete| | Attachment #54981|0 |1 is obsolete| | Attachment #54982|0 |1 is obsolete| | Attachment #54983|0 |1 is obsolete| | Attachment #54984|0 |1 is obsolete| | Attachment #54985|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54987&action=edit Bug 17216: Add Koha::AuthorisedValueCategory|ies classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54988&action=edit Bug 17216: Add new table authorised_value_categories and populate it This patch set adds a new table authorised_value_categories to store authori(s|z)ed value categories into a separate table. The problematic is explained on bug 15799 comment 4: We need FK to the AV categories but some may not have authorized values yet. What does this patch set: - Add a new authorised_value_categories table - Populate it with known categories - Update FK items_search_fields.authorised_values_category - Create a new FK marc_subfield_structure.authorised_value (FIXME should be authorised_value_categories instead) They are some problems this patch set do not take into account: - The .sql installer files won't insert correctly (will have to be updated when this patch set will be ready to be pushed) - All the categories (even the ones without authorized values defined) are listed when you edit frameworks (marc_subfield_structure.pl) - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". Test plan: 0/ Execute the DB entry to create and populate the new table and set the FK 1/ Create a new AV category from the admin module (admin/authorised_values.pl) 2/ Add/edit subfield linked to a AV category (admin/marc_subfield_structure.pl) 3/ You won't be allowed to add AV for branches, itemtypes or cn_source. They are used internally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54989&action=edit Bug 17216: Add some other AV categories Found in installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54990&action=edit Bug 17216: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54991&action=edit Bug 17216: Update the admin interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54992&action=edit Bug 17216: Add FK on mss.authorised_value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54993&action=edit Bug 17216: Use Koha::AVC from mss.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- - bug_17216_2_add_fk.sql is still missing a semicolon on the 'UPDATE marc_subfield_structure' line. - Shouldn't category be required in the "New category" form? - In testing the effect of these patches on marc_subfield_structure.pl, what should we be looking for? Simply that the categories show up correctly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54992|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55003&action=edit Bug 17216: Add FK on mss.authorised_value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54993|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55004&action=edit Bug 17216: Use Koha::AVC from mss.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55005&action=edit Bug 17216: Category name is required when adding a new AV cat -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #15)
- bug_17216_2_add_fk.sql is still missing a semicolon on the 'UPDATE marc_subfield_structure' line.
Oops, sorry about that. I have tested the file directly in the CLI, line by line, that's why I did not spot it.
- Shouldn't category be required in the "New category" form?
Yep, done.
- In testing the effect of these patches on marc_subfield_structure.pl, what should we be looking for? Simply that the categories show up correctly?
Yes. You will also think about the structure changes: now all the AV cat is displayed, when before only the AV cat *in used* were displayed. Think also about the "branches", "itemtypes" and "cn_source". does that make sense to have them in the table, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55008&action=edit Bug 17216: Add FK on authorised_values.category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55009&action=edit Bug 17216: Update DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55010&action=edit Bug 17216: Update DBIC schema for MSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55011&action=edit Bug 17216: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54987|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55021&action=edit [SIGNED-OFF] Bug 17216: Add Koha::AuthorisedValueCategory|ies classes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54988|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55022&action=edit [SIGNED-OFF] Bug 17216: Add new table authorised_value_categories and populate it This patch set adds a new table authorised_value_categories to store authori(s|z)ed value categories into a separate table. The problematic is explained on bug 15799 comment 4: We need FK to the AV categories but some may not have authorized values yet. What does this patch set: - Add a new authorised_value_categories table - Populate it with known categories - Update FK items_search_fields.authorised_values_category - Create a new FK marc_subfield_structure.authorised_value (FIXME should be authorised_value_categories instead) They are some problems this patch set do not take into account: - The .sql installer files won't insert correctly (will have to be updated when this patch set will be ready to be pushed) - All the categories (even the ones without authorized values defined) are listed when you edit frameworks (marc_subfield_structure.pl) - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". Test plan: 0/ Execute the DB entry to create and populate the new table and set the FK 1/ Create a new AV category from the admin module (admin/authorised_values.pl) 2/ Add/edit subfield linked to a AV category (admin/marc_subfield_structure.pl) 3/ You won't be allowed to add AV for branches, itemtypes or cn_source. They are used internally. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54989|0 |1 is obsolete| | --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55023&action=edit [SIGNED-OFF] Bug 17216: Add some other AV categories Found in installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54990|0 |1 is obsolete| | --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55024&action=edit [SIGNED-OFF] Bug 17216: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54991|0 |1 is obsolete| | --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55025&action=edit [SIGNED-OFF] Bug 17216: Update the admin interface Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55003|0 |1 is obsolete| | --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55026&action=edit [SIGNED-OFF] Bug 17216: Add FK on mss.authorised_value Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55004|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55027&action=edit [SIGNED-OFF] Bug 17216: Use Koha::AVC from mss.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55005|0 |1 is obsolete| | --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55028&action=edit [SIGNED-OFF] Bug 17216: Category name is required when adding a new AV cat Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55008|0 |1 is obsolete| | --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55029&action=edit [SIGNED-OFF] Bug 17216: Add FK on authorised_values.category Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55009|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55030&action=edit [SIGNED-OFF] Bug 17216: Update DBIC Schema Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55010|0 |1 is obsolete| | --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55031&action=edit [SIGNED-OFF] Bug 17216: Update DBIC schema for MSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55011|0 |1 is obsolete| | --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55032&action=edit [SIGNED-OFF] Bug 17216: Fix tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- These patches work well for me from the point of view of an end user. The patches apply, QA tools don't complain, and database updates correctly. I have followed the test plan successfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55047&action=edit Bug 17216: Fix other tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 [Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #38 from Claire Gravely <claire_gravely@hotmail.com> --- could not apply patch to test bug 17248. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55021|0 |1 is obsolete| | Attachment #55022|0 |1 is obsolete| | Attachment #55023|0 |1 is obsolete| | Attachment #55024|0 |1 is obsolete| | Attachment #55025|0 |1 is obsolete| | Attachment #55026|0 |1 is obsolete| | Attachment #55027|0 |1 is obsolete| | Attachment #55028|0 |1 is obsolete| | Attachment #55029|0 |1 is obsolete| | Attachment #55030|0 |1 is obsolete| | Attachment #55031|0 |1 is obsolete| | Attachment #55032|0 |1 is obsolete| | Attachment #55047|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55207&action=edit Bug 17216: Add Koha::AuthorisedValueCategory|ies classes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55208&action=edit Bug 17216: Add new table authorised_value_categories and populate it This patch set adds a new table authorised_value_categories to store authori(s|z)ed value categories into a separate table. The problematic is explained on bug 15799 comment 4: We need FK to the AV categories but some may not have authorized values yet. What does this patch set: - Add a new authorised_value_categories table - Populate it with known categories - Update FK items_search_fields.authorised_values_category - Create a new FK marc_subfield_structure.authorised_value (FIXME should be authorised_value_categories instead) They are some problems this patch set do not take into account: - The .sql installer files won't insert correctly (will have to be updated when this patch set will be ready to be pushed) - All the categories (even the ones without authorized values defined) are listed when you edit frameworks (marc_subfield_structure.pl) - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". Test plan: 0/ Execute the DB entry to create and populate the new table and set the FK 1/ Create a new AV category from the admin module (admin/authorised_values.pl) 2/ Add/edit subfield linked to a AV category (admin/marc_subfield_structure.pl) 3/ You won't be allowed to add AV for branches, itemtypes or cn_source. They are used internally. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55209&action=edit Bug 17216: Add some other AV categories Found in installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55210&action=edit Bug 17216: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55211&action=edit Bug 17216: Update the admin interface Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55212&action=edit Bug 17216: Add FK on mss.authorised_value Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55213&action=edit Bug 17216: Use Koha::AVC from mss.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55214&action=edit Bug 17216: Add FK on authorised_values.category Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55215&action=edit Bug 17216: Update DBIC Schema Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55216&action=edit Bug 17216: Update DBIC schema for MSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55217&action=edit Bug 17216: Fix tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55218&action=edit Bug 17216: Fix other tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch set fixes conflict with bug 11019. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55207|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55365&action=edit Bug 17216: Add Koha::AuthorisedValueCategory|ies classes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55208|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55366&action=edit Bug 17216: Add new table authorised_value_categories and populate it This patch set adds a new table authorised_value_categories to store authori(s|z)ed value categories into a separate table. The problematic is explained on bug 15799 comment 4: We need FK to the AV categories but some may not have authorized values yet. What does this patch set: - Add a new authorised_value_categories table - Populate it with known categories - Update FK items_search_fields.authorised_values_category - Create a new FK marc_subfield_structure.authorised_value (FIXME should be authorised_value_categories instead) They are some problems this patch set do not take into account: - The .sql installer files won't insert correctly (will have to be updated when this patch set will be ready to be pushed) - All the categories (even the ones without authorized values defined) are listed when you edit frameworks (marc_subfield_structure.pl) - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". Test plan: 0/ Execute the DB entry to create and populate the new table and set the FK 1/ Create a new AV category from the admin module (admin/authorised_values.pl) 2/ Add/edit subfield linked to a AV category (admin/marc_subfield_structure.pl) 3/ You won't be allowed to add AV for branches, itemtypes or cn_source. They are used internally. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55209|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55367&action=edit Bug 17216: Add some other AV categories Found in installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55210|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55368&action=edit Bug 17216: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55211|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55369&action=edit Bug 17216: Update the admin interface Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55212|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55370&action=edit Bug 17216: Add FK on mss.authorised_value Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55213|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55371&action=edit Bug 17216: Use Koha::AVC from mss.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55214|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55372&action=edit Bug 17216: Add FK on authorised_values.category Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55215|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55373&action=edit Bug 17216: Update DBIC Schema Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55216|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55374&action=edit Bug 17216: Update DBIC schema for MSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55217|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55375&action=edit Bug 17216: Fix tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55218|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55376&action=edit Bug 17216: Fix other tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17249 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 [Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, mostly good - please take a look: Administration > Authorized values 1) I think the 'virtual' authorized values branches, itemtypes and cn_sort should not show up in the authorized value list in administration. It's not a nice effect that it looks like you can add to them and then get an error message - we should avoid that kind of user experience. 2) Small typo when adding to 'branches'. Should be: The authorized value categories 'branches', 'itemtypes' and 'cn_source' are used internally by Koha and are not valid. 3) If you typo in an authorized value category, there is no way to remove it. That can get annoying pretty fast. We should offer a way to delete an empty authorized value category (maybe if not empty too?). 4) The new empty option in the pull down list leads to some confusing display: Authorized values for category : There are no authorized values defined for Editing items 5) There is a problem with the STACK on 952$j as this doesn't exist. Should we clean it up by removing it from the frameworks if there are no values defined for it? Authority types 6) Should we add the same FK relationship there? (separate bug?) Successfully tested: - Bibliographic MARC frameworks - Cataloguing - Patron attribute types / Patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55692&action=edit Bug 17216: Do not display branches, itemtypes and cn_source -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55693&action=edit Bug 17216: Do no display the empty string category name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #64)
Hi Jonathan, mostly good - please take a look:
Administration > Authorized values
1) I think the 'virtual' authorized values branches, itemtypes and cn_sort should not show up in the authorized value list in administration. It's not a nice effect that it looks like you can add to them and then get an error message - we should avoid that kind of user experience.
Done, removed.
2) Small typo when adding to 'branches'. Should be: The authorized value categories 'branches', 'itemtypes' and 'cn_source' are used internally by Koha and are not valid.
Done, thanks.
3) If you typo in an authorized value category, there is no way to remove it. That can get annoying pretty fast. We should offer a way to delete an empty authorized value category (maybe if not empty too?).
Yes, it's in the TODO section of the commit msg.
4) The new empty option in the pull down list leads to some confusing display: Authorized values for category : There are no authorized values defined for
Fixed, the empty one is no longer displayed.
Editing items
5) There is a problem with the STACK on 952$j as this doesn't exist. Should we clean it up by removing it from the frameworks if there are no values defined for it?
I have not found regression with master. So let's deal with it on another bug report.
Authority types 6) Should we add the same FK relationship there? (separate bug?)
Yes, and others as well. But that should be done on another bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, this is looking good, but I found something a bit disturbing (to me :) ): Try to add an authorized value category "Branches". The system tells you, that the category already exists. But: It will allow you then to add a new value to it. Can we show the "used internally message" and now allow to do that? I will move the "delete category" to a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 [Bug 17355] Allow deletion of authorised value categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55835&action=edit Bug 17216: Internal AV should be correctly handled when creating a new category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Cool, thx Jonathan - one last thing - could you take a look at the installer files? You noted that before this is pushed we need to fix the files there. I think this is really close to PQA now. Could we handle this like sysprefs.sql having one file on top level used for all? I think we got no need for translations here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17357 [Bug 17357] WTHDRAWN is still used in installer files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17358 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17358 [Bug 17358] Authorised values: COU>COUNTRY | LAN>LANG -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55840&action=edit Bug 17216: Move the AV cat list file to the top level This way it will get used for any languages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17360 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #70)
Cool, thx Jonathan - one last thing - could you take a look at the installer files?
You noted that before this is pushed we need to fix the files there. I think this is really close to PQA now.
Could we handle this like sysprefs.sql having one file on top level used for all? I think we got no need for translations here.
Done, see the last patch. You can use the script from bug 17360 to test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56202&action=edit [PASSED QA] Bug 17216: Add Koha::AuthorisedValueCategory|ies classes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56203&action=edit [PASSED QA] Bug 17216: Add new table authorised_value_categories and populate it This patch set adds a new table authorised_value_categories to store authori(s|z)ed value categories into a separate table. The problematic is explained on bug 15799 comment 4: We need FK to the AV categories but some may not have authorized values yet. What does this patch set: - Add a new authorised_value_categories table - Populate it with known categories - Update FK items_search_fields.authorised_values_category - Create a new FK marc_subfield_structure.authorised_value (FIXME should be authorised_value_categories instead) They are some problems this patch set do not take into account: - The .sql installer files won't insert correctly (will have to be updated when this patch set will be ready to be pushed) - All the categories (even the ones without authorized values defined) are listed when you edit frameworks (marc_subfield_structure.pl) - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". Test plan: 0/ Execute the DB entry to create and populate the new table and set the FK 1/ Create a new AV category from the admin module (admin/authorised_values.pl) 2/ Add/edit subfield linked to a AV category (admin/marc_subfield_structure.pl) 3/ You won't be allowed to add AV for branches, itemtypes or cn_source. They are used internally. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56204&action=edit [PASSED QA] Bug 17216: Add some other AV categories Found in installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56205&action=edit [PASSED QA] Bug 17216: DBIC Schema changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56206&action=edit [PASSED QA] Bug 17216: Update the admin interface Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #78 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56207&action=edit [PASSED QA] Bug 17216: Add FK on mss.authorised_value Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56208&action=edit [PASSED QA] Bug 17216: Use Koha::AVC from mss.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56209&action=edit [PASSED QA] Bug 17216: Add FK on authorised_values.category Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56210&action=edit [PASSED QA] Bug 17216: Update DBIC Schema Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56211&action=edit [PASSED QA] Bug 17216: Update DBIC schema for MSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56212&action=edit [PASSED QA] Bug 17216: Fix tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56213&action=edit [PASSED QA] Bug 17216: Fix other tests Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56214&action=edit [PASSED QA] Bug 17216: Do not display branches, itemtypes and cn_source Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #86 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56215&action=edit [PASSED QA] Bug 17216: Do no display the empty string category name Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #87 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56216&action=edit [PASSED QA] Bug 17216: Internal AV should be correctly handled when creating a new category Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56217&action=edit [PASSED QA] Bug 17216: Move the AV cat list file to the top level This way it will get used for any languages. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55368|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55372|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55373|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55375|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55693|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55692|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 [Bug 5670] Housebound Readers Module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #89 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56619&action=edit Bug 17216: Revert changes to ItemsSearchField schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #90)
Created attachment 56619 [details] [review] Bug 17216: Revert changes to ItemsSearchField schema file
@RM, could you please push this follow-up please? It seems that I have generated a wrong file (80 vs 32). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #92 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #91)
(In reply to Jonathan Druart from comment #90)
Created attachment 56619 [details] [review] [review] Bug 17216: Revert changes to ItemsSearchField schema file
@RM, could you please push this follow-up please? It seems that I have generated a wrong file (80 vs 32).
Thanks! Pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17538 [Bug 17538] t/db_dependent/Upload.t is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540 [Bug 17540] auth_values_input_www.t is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #93 from Mirko Tietgen <mirko@abunchofthings.net> --- With a Debian package for 16.11, on upgrade from 16.05 the following happens: Upgrade to 16.06.00.032 done (Bug 17357 - WTHDRAWN is still used in installer files) DBD::mysql::db do failed: Can't create table 'koha_upgrade.#sql-329_a5' (errno: 150) [for Statement " ALTER TABLE marc_subfield_structure MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL, ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET NULL; "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 13175. Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store authorized value categories) I assume it is related to this bug? Is it safe to ignore? It does sound more scary than the duplicate warnings we get from time to time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #94 from Mirko Tietgen <mirko@abunchofthings.net> --- FYI: I'll wait with the package release for 16.11.00 until this is solved. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57729&action=edit Bug 17216: Fix SQL statement to setting marc_subfield_structure.authorised_value to NULL We want to update it if it's empty, not equal to ';' nopaste vim mode is to blame -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #96 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Mirko Tietgen from comment #93)
With a Debian package for 16.11, on upgrade from 16.05 the following happens:
Upgrade to 16.06.00.032 done (Bug 17357 - WTHDRAWN is still used in installer files) DBD::mysql::db do failed: Can't create table 'koha_upgrade.#sql-329_a5' (errno: 150) [for Statement " ALTER TABLE marc_subfield_structure MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL, ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET NULL; "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 13175. Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store authorized value categories)
I assume it is related to this bug? Is it safe to ignore? It does sound more scary than the duplicate warnings we get from time to time.
Got the same error in my test setup. For undetermined reason, authorised_value field in marc_subfield_structure table did not have utf8_unicode_ci collation. I replaced MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL, with MODIFY COLUMN authorised_value VARCHAR(32) CHARACTER SET utf8 COLLATE utf8_unicode_ci DEFAULT NULL, and after that it seems to work fine. No idea why this DB update is tagged with "Bug 17357 - WTHDRAWN is still used in installer files)" and not with a "Bug 17216 ..." instead. BTW, there are some other text fields in my test DB with inconsistent collation too, but this is a database with a long history of accumulated DB updates (including various unstable / atomic ones). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Got the same error in my test setup. For undetermined reason, authorised_value >field in marc_subfield_structure table did not have utf8_unicode_ci collation.
That's intentional. ci = case insensitive breaks uppercase subfield codes which are often used to create additional fields in 952. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl --- Comment #98 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #97)
Got the same error in my test setup. For undetermined reason, authorised_value >field in marc_subfield_structure table did not have utf8_unicode_ci collation.
That's intentional. ci = case insensitive breaks uppercase subfield codes which are often used to create additional fields in 952.
marc_subfield_structure.tagsubfield indeed has utf8_bin collation, but should the same rule apply for authorised_value? By default (in fresh installs), marc_subfield_structure.authorised_value has utf8_unicode_ci collation, for some reasons (I still have no idea why, maybe update from Bug 11944 partially failed) in my old test DB, this field has no collation defined, and that's why adding FK failed for me with error 150. But it can be failing for different reason[s] for other people - and probably is, this collation issue seems to be some kind of problem which was specific to this particular DB. There is one other table (overduerules) in that DB which does not have utf8_unicode_ci collation set by default for all text fields, but it looks more like an omission in updatedatabase (Bug 13624, DB version: 3.23.00.007). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #99 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Jacek Ablewicz from comment #96)
No idea why this DB update is tagged with "Bug 17357 - WTHDRAWN is still used in installer files)" and not with a "Bug 17216 ..." instead.
Uhm, scratch that; in fact it is tagged correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #100 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- Huh, this is what happens (mysql 5.5.49): for a table with no default collation defined on table level (like marc_subfield_structure) MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL does not preserve existing collation for that field (which was, after all, utf8_unicode_ci in my test DB before attempting that upgrade: manually set up to utf8_unicode_ci for a bunch of marc_subfield_structure fields in DB update from Bug 11944), and it subsequently fails with error 150 on adding FK constraint because of collations inconsistency (I think.. not quite sure, but a solution from comment #96 fixes this problem). It's reproductible; note that I have different default collation defined mysql server-side on that box (utf8_general_ci) - if it was utf8_unicode_ci server-side, I guess there is a possibility this issue does not manifest itself (?). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #101 from Mirko Tietgen <mirko@abunchofthings.net> --- Did an install with the latest patch added, got Update errors : [Thu Nov 24 00:06:08 2016] updatedatabase.pl: DBD::mysql::db do failed: Duplicate column name 'updated_on' [for Statement " [Thu Nov 24 00:06:08 2016] updatedatabase.pl: ALTER TABLE borrowers [Thu Nov 24 00:06:08 2016] updatedatabase.pl: ADD COLUMN updated_on timestamp NULL DEFAULT CURRENT_TIMESTAMP [Thu Nov 24 00:06:08 2016] updatedatabase.pl: ON UPDATE CURRENT_TIMESTAMP [Thu Nov 24 00:06:08 2016] updatedatabase.pl: AFTER privacy_guarantor_checkouts; [Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 12626. [Thu Nov 24 00:06:08 2016] updatedatabase.pl: DBD::mysql::db do failed: Duplicate column name 'updated_on' [for Statement " [Thu Nov 24 00:06:08 2016] updatedatabase.pl: ALTER TABLE deletedborrowers [Thu Nov 24 00:06:08 2016] updatedatabase.pl: ADD COLUMN updated_on timestamp NULL DEFAULT CURRENT_TIMESTAMP [Thu Nov 24 00:06:08 2016] updatedatabase.pl: ON UPDATE CURRENT_TIMESTAMP [Thu Nov 24 00:06:08 2016] updatedatabase.pl: AFTER privacy_guarantor_checkouts; [Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 12632. [Thu Nov 24 00:06:15 2016] updatedatabase.pl: DBD::mysql::db do failed: Can't create table 'koha_koha.#sql-2221_18d' (errno: 150) [for Statement " [Thu Nov 24 00:06:15 2016] updatedatabase.pl: ALTER TABLE marc_subfield_structure [Thu Nov 24 00:06:15 2016] updatedatabase.pl: MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL, [Thu Nov 24 00:06:15 2016] updatedatabase.pl: ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET NULL; [Thu Nov 24 00:06:15 2016] updatedatabase.pl: "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 13175. @Jacek: that is what you are talking about, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #102 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Mirko Tietgen from comment #101)
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 12632. [Thu Nov 24 00:06:15 2016] updatedatabase.pl: DBD::mysql::db do failed: Can't create table 'koha_koha.#sql-2221_18d' (errno: 150) [for Statement " [Thu Nov 24 00:06:15 2016] updatedatabase.pl: ALTER TABLE marc_subfield_structure [Thu Nov 24 00:06:15 2016] updatedatabase.pl: MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL, [Thu Nov 24 00:06:15 2016] updatedatabase.pl: ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET NULL; [Thu Nov 24 00:06:15 2016] updatedatabase.pl: "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 13175.
@Jacek: that is what you are talking about, right?
Possibly ;), hard to tell (errno: 150 by itself is not very informative). What I did while trying to troubleshoot this problem (following the guidelines from <http://stackoverflow.com/questions/4061293/mysql-cant-create-table-errno-150>, especially nr 4 is quite helpful): - split erroneous statement in two 1) ALTER TABLE marc_subfield_structure MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL; 2) ALTER TABLE marc_subfield_structure ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET NULL; - part 1) executed OK, but part 2) still resulted in the same error (150) - noticed that after 1), utf8_unicode_ci collation is no longer there for authorised_value field (mysqldump --no-data marc_subfield_structure) - replaced 1) with ALTER TABLE marc_subfield_structure MODIFY COLUMN authorised_value VARCHAR(32) CHARACTER SET utf8 COLLATE utf8_unicode_ci DEFAULT NULL; - re-run 1) and 2) - no error, FK constrain got created successfully and collation for authorised_value is utf8_unicode_ci. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #103 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- All of this sounds related to bug 13810 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676 [Bug 17676] Default COLLATE for marc_subfield_structure is not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #104 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am going to provide a patch on bug 17676 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch set adds a new release notes| |table | |authorised_value_categories | |to store authori(s|z)ed | |value categories into a | |separate table. The | |problematic is explained on | |bug 15799 comment 4: | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15799#c4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097 [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #105 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #95)
Created attachment 57729 [details] [review] Bug 17216: Fix SQL statement to setting marc_subfield_structure.authorised_value to NULL
We want to update it if it's empty, not equal to ';' nopaste vim mode is to blame
This is not in, we absolutely need it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 --- Comment #106 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This changed an existing database entry - what about the installations that have already updated to 16.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18248 --- Comment #107 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please use bug 18248 for follow-ups! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 [Bug 18248] Add missing patch from 17216 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 [Bug 18248] Add missing patch from 17216 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248 [Bug 18248] Add missing patch from 17216 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144 [Bug 21144] ROADTYPE missing from authorised value categories list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730 [Bug 21730] PA_CLASS missing from list of authorized values categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36395 [Bug 36395] Useless fetch of AV categories in admin/marc_subfields_structure.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org