[Bug 19401] New: No confirm message when deleting an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Bug ID: 19401 Summary: No confirm message when deleting an invoice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org To reproduce 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 67541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67541&action=edit Bug 19401: Add confirm message when deleting invoice To test: 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly 7) Apply patch and repeat steps 4 and 5 8) Confirm the confirm message shows and works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Academy: Requires that you order and receive something first, but easy to test if you already have some acq data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No confirm message when |No confirm message when |deleting an invoice |deleting an invoice from | |invoice detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67541|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67794&action=edit Bug 19401: Add confirm message when deleting invoice To test: 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly 7) Apply patch and repeat steps 4 and 5 8) Confirm the confirm message shows and works as expected Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19429 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, this works nicely! I have filed another bug report for the invoice search page that is also missing the confirmation message: bug 19429 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67794|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70025&action=edit Bug 19401: Add confirm message when deleting invoice To test: 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly 7) Apply patch and repeat steps 4 and 5 8) Confirm the confirm message shows and works as expected Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, what would be the best pattern to follow here? I think id="delete" is not specific enough, it should be id="delete_invoice" id or class? See bug 19429. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I think "delete_invoice" is better, but it's more a matter of style than functionality. ids should always be unique, so if we're validating the markup as we go we'll be warned about duplicates. On this page an id is the right choice over a class because it will always be a unique element. In Bug 19429 it must be a class because the element repeats for each invoice in the table which can be deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 [Bug 19753] Move template JavaScript to the footer: Acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org