[Bug 39502] New: Web Usability Accessibility Audit - Decorative Images Don't Need alt Text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Bug ID: 39502 Summary: Web Usability Accessibility Audit - Decorative Images Don't Need alt Text Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: alexander.blanchard@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org The accessibility audit has highlighted that there are icons across the site that are used to define the different types of content available in the library catalogue. Often these icons are used alongside text that also describes the content types available. Where this is the case, a screen reader user hears the same content twice. Some decorative images are also announced by their file name. The report has highlighted that for screen readers, these names are often too long and confusing. These findings may impact the experience of screen reader users. The suggested solution is for purely decorative images to have null alt text. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexander.blanchard@openfif |ity.org |th.co.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 --- Comment #1 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181843&action=edit Bug 39502: Web Usability: Decorative Images Do Not Need ALT Text A accessibility audit has highlighted that some of the decorative images on the opac have alt text which is often followed by a spen that also contains the same text. This results in screen readers reading this information twice. The suggested solution is to set the alt text to null in these instances. Test Plan: Prior to applying patch: 1) Navigate to Koha OPAC 2) Carry out a search 3) On one of the records right click on the Material Type: under the heading 4) Select Inspect 5) Note that the image has an alt text that matches the span that follows 6) Click on the item title and repeat the process for the icon below the contributors. 7) Scroll down to the holdings table and repeat the process for the image in the Item Type column 8) Log in as a user with at least one checkout 9) Navigate to the Checkout History table and repeat the process for the icon in the itype column 10) Apply the patch 11) Repeat the steps above and notice that the alt is now null in order to ignored by screen readers 12) Note that for the Dev tools may show alt but if you right click on the page and select View Page Source you will see that the code is alt="" as expected by screen readers 13) Note that for alt tags that have been updated in the xsl files e.g. the small icons that follow 'Material Type: ' may be cached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lin-wei.li@inLibro.com Status|Needs Signoff |Failed QA --- Comment #2 from Lin Wei <lin-wei.li@inLibro.com> --- # Test Environment - OS: Ubuntu 24.04.2 LTS - Browser: Firefox 138.0.1 (64-bit) # Issues with Test Plan - Step 6: Skipped this step: instruction unclear. # Results before Applying Patch - Step 5: Expected behavior: the image has an alt text equal to the span after it. - Step 6: Expected behavior: the image has an alt text equal to the span after it. - Step 7: Expected behavior: the image has an alt text equal to the span after it. - Step 9: Unexpected behavior: the checkout history of my account has an entry with "Item type: Books" where the image already has an empty alt text. # Results after Applying Patch - Step 5: Expected behavior: the image has no alt text. - Step 6: Unexpected behavior: the image still has an alt text. - Step 7: Expected behavior: the image has no alt text. - Step 9: Expected behavior: the image has no alt text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 --- Comment #3 from Lin Wei <lin-wei.li@inLibro.com> --- (In reply to Lin Wei from comment #2)
# Issues with Test Plan
- Step 6: Skipped this step: instruction unclear.
Please disregard this section: my system was not set up properly in the beginning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181843|0 |1 is obsolete| | --- Comment #4 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 182548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182548&action=edit Bug 39502: Web Usability: Decorative Images Do Not Need ALT Text A accessibility audit has highlighted that some of the decorative images on the opac have alt text which is often followed by a spen that also contains the same text. This results in screen readers reading this information twice. The suggested solution is to set the alt text to null in these instances. Test Plan: Prior to applying patch: 1) Navigate to Koha OPAC 2) Carry out a search 3) On one of the records right click on the Material Type: under the heading 4) Select Inspect 5) Note that the image has an alt text that matches the span that follows 6) Click on the item title and repeat the process for the icon below the contributors. 7) Scroll down to the holdings table and repeat the process for the image in the Item Type column 8) Apply the patch 9) Repeat the steps above and notice that the alt is now null in order to ignored by screen readers 11) Note that for the Dev tools may show alt but if you right click on the page and select View Page Source you will see that the code is alt="" as expected by screen readers 12) Note that for alt tags that have been updated in the xsl files e.g. the small icons that follow 'Material Type: ' may be cached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 --- Comment #5 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Updated the patch to account for the unexpected behaviour in step 6. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182548|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 182690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182690&action=edit Bug 39502: Web Usability: Decorative Images Do Not Need ALT Text A accessibility audit has highlighted that some of the decorative images on the opac have alt text which is often followed by a spen that also contains the same text. This results in screen readers reading this information twice. The suggested solution is to set the alt text to null in these instances. Test Plan: Prior to applying patch: 1) Navigate to Koha OPAC 2) Carry out a search 3) On one of the records right click on the Material Type: under the heading 4) Select Inspect 5) Note that the image has an alt text that matches the span that follows 6) Click on the item title and repeat the process for the icon below the contributors. 7) Scroll down to the holdings table and repeat the process for the image in the Item Type column 8) Apply the patch 9) Repeat the steps above and notice that the alt is now null in order to ignored by screen readers 11) Note that for the Dev tools may show alt but if you right click on the page and select View Page Source you will see that the code is alt="" as expected by screen readers 12) Note that for alt tags that have been updated in the xsl files e.g. the small icons that follow 'Material Type: ' may be cached. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jake.deery@openfifth.co.uk --- Comment #7 from Jake Deery <jake.deery@openfifth.co.uk> --- Could we get a rebase on this one? Unfortunately, it no longer applies. Ta, Jake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #8 from Jake Deery <jake.deery@openfifth.co.uk> --- Disregard, I had a silly branch checked out. Works great! Returning to signed off. Ta, Jake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182690|0 |1 is obsolete| | --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184412&action=edit Bug 39502: Web Usability: Decorative Images Do Not Need ALT Text A accessibility audit has highlighted that some of the decorative images on the opac have alt text which is often followed by a spen that also contains the same text. This results in screen readers reading this information twice. The suggested solution is to set the alt text to null in these instances. Test Plan: Prior to applying patch: 1) Navigate to Koha OPAC 2) Carry out a search 3) On one of the records right click on the Material Type: under the heading 4) Select Inspect 5) Note that the image has an alt text that matches the span that follows 6) Click on the item title and repeat the process for the icon below the contributors. 7) Scroll down to the holdings table and repeat the process for the image in the Item Type column 8) Apply the patch 9) Repeat the steps above and notice that the alt is now null in order to ignored by screen readers 11) Note that for the Dev tools may show alt but if you right click on the page and select View Page Source you will see that the code is alt="" as expected by screen readers 12) Note that for alt tags that have been updated in the xsl files e.g. the small icons that follow 'Material Type: ' may be cached. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 --- Comment #10 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184413&action=edit Bug 39502: (QA follow-up) Remove title attribute as well When an element should be ignored by screen readers, it should have no title attribute or an empty title attribute, in addition to a null alt attribute. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 24.11.x, please provide a dedicated patch if possible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.12 released in| | --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.12 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39502 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org