[Bug 16216] New: Circulation_Branch.t doesn't set itemtype for test data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Bug ID: 16216 Summary: Circulation_Branch.t doesn't set itemtype for test data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com Bug 14598 introduces a warning for items without itemtypes. This makes Circulation_Branch.t raise warnings. To reproduce: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |14598 Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49994&action=edit Bug 16216: Circulation_Branch.t doesn't set itemtype for test data This patch makes the tests create better data for them: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised - Apply the patch - Run $ prove t/db_dependent/Circulation_Branch.t => SUCCESS: No warnings raised - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49994|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 49995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49995&action=edit [SIGNED-OFF]Bug 16216: Circulation_Branch.t doesn't set itemtype for test data This patch makes the tests create better data for them: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised - Apply the patch - Run $ prove t/db_dependent/Circulation_Branch.t => SUCCESS: No warnings raised - Sign off Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49995|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50009&action=edit [PASSED QA] Bug 16216: Circulation_Branch.t doesn't set itemtype for test data This patch makes the tests create better data for them: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised - Apply the patch - Run $ prove t/db_dependent/Circulation_Branch.t => SUCCESS: No warnings raised - Sign off Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successful Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! (more tests I love it) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Why is this pushed if it depends on bug 14598 (which is Signed Off) ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14598 | Blocks| |14598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org