[Bug 22550] New: OPAC suggestion form doesn't require mandatory fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Bug ID: 22550 Summary: OPAC suggestion form doesn't require mandatory fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 13618 Target Milestone: --- The OPAC suggestion form requires JavaScript to perform validation of mandatory fields. The configuration of required fields is incorrectly escaped with the html filter and thus breaks, breaking validation. The $raw filter should be used instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86823&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields This patch changes the template filter on the [% mandatoryfields %] template variable. The variable outputs JSON, so it should have the $raw filter. To test suggestions must be enabled in the OPAC. Apply the patch and go to Purchase suggestions -> New suggestion. In the form, required fields should be labeled in red. It should not be possible to submit the form without filling in these fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86823|0 |1 is obsolete| | --- Comment #2 from Bin <bin.wen@inlibro.com> --- Created attachment 86926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86926&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86926|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86942&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86942|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86943&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 T. Jogi Raju <rajujogi.t@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |rajujogi.t@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86943|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 86959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86959&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- this isn't necessary in 18.05, not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Blocks| |22800 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The usage of raw could be avoided here, I have opened bug 22800 to remove it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org