[Bug 22610] New: SIP Payment Types should be moved out of accountype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Bug ID: 22610 Summary: SIP Payment Types should be moved out of accountype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 18786 introduced a dedicated payment_type field to the database and an authorized value for it's population.. we should move the SIP payment type appendages from accounttype into this AV list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17702 Depends on| |18786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 [Bug 18786] Add ability to create custom payment types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88619&action=edit Bug 22610: Update SIP payment accounttypes This DB update updates the Pay00, Pay01 and Pay02 accounttypes to all be 'Pay' and adds the corresponding payment_types into the authorised_values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88620&action=edit Bug 22610: Update SIP2 to use payment_type The SIP2 interface has long used a set of accounttypes to denote payment types. Now we have an authorised list of payment_types and a payment_type field in accountlines this patch alters the logic to use it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88619|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89460&action=edit Bug 22610: Update SIP payment accounttypes This DB update updates the Pay00, Pay01 and Pay02 accounttypes to all be 'Pay' and adds the corresponding payment_types into the authorised_values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88620|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89461&action=edit Bug 22610: Update SIP2 to use payment_type The SIP2 interface has long used a set of accounttypes to denote payment types. Now we have an authorised list of payment_types and a payment_type field in accountlines this patch alters the logic to use it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Freshly rebased. Test Plan: 1) Check for presence of Pay01, Pay02 and Pay03 accounttypes in your database 2) Apply first patch and notice those occurrences have all changed to 'Pay' and an appropriate 'payment_type' has been set to catch the '01', '02' and '03' meanings 3) Apply second patch 4) Do some payments via SIP2 and note no new Pay01 etc accounttypes are created and instead payment types are populated for the appropriate lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89470&action=edit Bug 22610: (follow-up) Catch non-standard SIP codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89470|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89471&action=edit Bug 22610: (follow-up) Catch non-standard SIP codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- I think libraries are going to miss these: [% CASE 'Pay00' %]Payment (cash via SIP2) [% CASE 'Pay01' %]Payment (VISA via SIP2) [% CASE 'Pay02' %]Payment (credit card via SIP2) Right now, *near as I can tell* we are only ever going to get "Cash via SIP2" in the interface with this patch, is that correct? I tried with the following sip emulator settings: I'd expect this to be Credit Card in the interface: kohadev-koha@b46acddf5bb7:/kohadevbox/koha$ perl misc/sip_cli_emulator.pl --sip_user=term1 --sip_pass=term1 --patron=2 --item='12' --fee-amount=15.00 --fee-type=03 -m fee_paid -a 127.0.0.1 -p 6001 -l MAIN I'd expect this to be VISA in the interface: kohadev-koha@b46acddf5bb7:/kohadevbox/koha$ perl misc/sip_cli_emulator.pl --sip_user=term1 --sip_pass=term1 --patron=2 --item='12' --fee-amount=15.00 --fee-type=02 -m fee_paid -a 127.0.0.1 -p 6001 -l MAIN This one is correct, the default 01, with Cash: kohadev-koha@b46acddf5bb7:/kohadevbox/koha$ perl misc/sip_cli_emulator.pl --sip_user=term1 --sip_pass=term1 --patron=2 --item='12' --fee-amount=15.00 -m fee_paid -a 127.0.0.1 -p 6001 -l MAIN Is there something I need to change in my setup here to make this work the way libraries will expect? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- actually, I'm wrong about the numbers, but we're still not getting the right SIP fee type for the different codes. The emulator defaults to 01, which is VISA, but it says Cash in the description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Liz Rea from comment #8)
I think libraries are going to miss these:
[% CASE 'Pay00' %]Payment (cash via SIP2) [% CASE 'Pay01' %]Payment (VISA via SIP2) [% CASE 'Pay02' %]Payment (credit card via SIP2)
Will they really miss the above? We've not gotten right of the data, only moved it into the more appropriate field 'payment_type' as apposed to lumping it in with 'accounttype'. That field is pretty much always displayed next to the accounttype column so I don't understand what they'll miss?
Right now, *near as I can tell* we are only ever going to get "Cash via SIP2" in the interface with this patch, is that correct? I tried with the following sip emulator settings:
I'm looking into this now as well as writing the unit tests. Thanks for testing :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right, I've gotten to the bottom of this.. it's tester error :).. man SIP is 'fun' to test. So, I tested with: perl misc/sip_cli_emulator.pl --sip_user=staff --sip_pass=staff --patron=dir --fee-identifier=697 --fee-amount=0.50 --payment-type=02 -m fee_paid -a 127.0.0.1 -p 6001 -l MAIN Note the 'payment-type' as apposed to 'fee-type' used in your version.. to be entirely honest I have no idea what fee-type is used for here.. I would suggest it's not for payment but for creation of new fee's only? Anywho.. the code does appear to work as expected (defaulting to 'Cash' when no payment-type is specified, but using the payment type if one is). Just about to upload a Unit test now too. Thanks again for testing Liz :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89460|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89492&action=edit Bug 22610: Update SIP payment accounttypes This DB update updates the Pay00, Pay01 and Pay02 accounttypes to all be 'Pay' and adds the corresponding payment_types into the authorised_values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89461|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89493&action=edit Bug 22610: Update SIP2 to use payment_type The SIP2 interface has long used a set of accounttypes to denote payment types. Now we have an authorised list of payment_types and a payment_type field in accountlines this patch alters the logic to use it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89471|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89494&action=edit Bug 22610: (follow-up) Catch non-standard SIP codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89495&action=edit Bug 22610: (follow-up) Correction to accounts tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89496&action=edit Bug 22610: (QA follow-up) Add unit tests for FeePayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89492|0 |1 is obsolete| | Attachment #89493|0 |1 is obsolete| | Attachment #89494|0 |1 is obsolete| | Attachment #89495|0 |1 is obsolete| | Attachment #89496|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89498&action=edit Bug 22610: Update SIP payment accounttypes This DB update updates the Pay00, Pay01 and Pay02 accounttypes to all be 'Pay' and adds the corresponding payment_types into the authorised_values Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89499&action=edit Bug 22610: Update SIP2 to use payment_type The SIP2 interface has long used a set of accounttypes to denote payment types. Now we have an authorised list of payment_types and a payment_type field in accountlines this patch alters the logic to use it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89500&action=edit Bug 22610: (follow-up) Catch non-standard SIP codes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89501&action=edit Bug 22610: (follow-up) Correction to accounts tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89502&action=edit Bug 22610: (QA follow-up) Add unit tests for FeePayment Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89503&action=edit Bug 22610: (QA follow-up) Make upgrade query more accurate Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #23 from Liz Rea <wizzyrea@gmail.com> --- awesome, I'm happy if y'all are happy :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is it really useful to check for the others PayXX (in the updatedatabase entry)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why not switch the sip_type (00, 01, 02) to something meaningful? Also, we are loosing the translation... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #24)
Is it really useful to check for the others PayXX (in the updatedatabase entry)?
(In reply to Jonathan Druart from comment #25)
Why not switch the sip_type (00, 01, 02) to something meaningful?
The types come directly from the SIP messages. That's part of the point of doing this, it allows for SIP extensions and types we are not currently handling by allowing users to add them as authorized values of the for SIPXX where the XX is the code they've found to be in use. It allows them to add a meaningful description of the type of payment. (For example, if 3M decided to have a unit that accepted paypal and assigned if 05 arbitrarily).
Also, we are loosing the translation...
Yup, I was sort of hoping no-one would mind this at the moment (none of the payment_types are translatable as it stands). This was meant to be a step towards bug 17702 (or perhaps I'll add another step between this and that bug) where I intend to make split accounttypes into credit and debit types and also move payment_types out of the authorized value system and into their own specialised table. I intend to make all of that translatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #26)
(In reply to Jonathan Druart from comment #24)
Also, we are loosing the translation...
Yup, I was sort of hoping no-one would mind this at the moment (none of the payment_types are translatable as it stands). This was meant to be a step towards bug 17702 (or perhaps I'll add another step between this and that bug) where I intend to make split accounttypes into credit and debit types and also move payment_types out of the authorized value system and into their own specialised table. I intend to make all of that translatable.
As it is a regression I think it should be fixed here. Why not simply keep (and adjust) the lines in the templates? (if authorised_values eq "Payment (cash via SIP2)" then display "Payment (cash via SIP2)") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good idea, that would work in the interim. Thanks for the suggestion Jonathan.. sometimes I just can't see the wood for the trees! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_05_candidate | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23049 Depends on|23049 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20307 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 [Bug 20307] Language overlay for authorized values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89498|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91638&action=edit Bug 22610: Update SIP payment accounttypes This DB update updates the Pay00, Pay01 and Pay02 accounttypes to all be 'Pay' and adds the corresponding payment_types into the authorised_values Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89499|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91639&action=edit Bug 22610: Update SIP2 to use payment_type The SIP2 interface has long used a set of accounttypes to denote payment types. Now we have an authorised list of payment_types and a payment_type field in accountlines this patch alters the logic to use it. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89500|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91640&action=edit Bug 22610: (follow-up) Catch non-standard SIP codes Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89501|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91641&action=edit Bug 22610: (follow-up) Correction to accounts tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89502|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91642&action=edit Bug 22610: (QA follow-up) Add unit tests for FeePayment Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89503|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91643&action=edit Bug 22610: (QA follow-up) Make upgrade query more accurate Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #36 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Reports note**: SIP2 release notes| |`accounttypes` have been | |deprecated in favour of | |using standard accounttypes | |across transactions in the | |accountlines. Reports | |should be updated to use | |`payment_type` to | |distinguish between the | |diffrent SIP2 payment type | |as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Reports note**: SIP2 |**Reports note**: SIP2 release notes|`accounttypes` have been |`accounttypes` have been |deprecated in favour of |deprecated in favour of |using standard accounttypes |using standard accounttypes |across transactions in the |across transactions in the |accountlines. Reports |accountlines. Reports |should be updated to use |should be updated to use |`payment_type` to |`payment_type` to |distinguish between the |distinguish between the |diffrent SIP2 payment type |different SIP2 payment type |as required. |as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 [Bug 24339] SIP codes are missing from the default payment_types on installation -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org