[Bug 31837] New: Add page-section to batch record deletion (tools)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Bug ID: 31837 Summary: Add page-section to batch record deletion (tools) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 Blocks: 31757 When receiving a shipment, the list of pending and then received orders (table below the first one) requires the treatment with page-section classes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142217&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add page-section to batch |Add page-section to |record deletion (tools) |basket.tt Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142217|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142232&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one is confusing to me... it fixes the basket page, but it looks like I intended to file for parcels? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add page-section to |Add page-section to basket |basket.tt |summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I see waht happened here... this is actually the fix for bug 31820 :P I'll switch things around a bit, so we also have a bug for the receive page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31906 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, compared this to some other pages and it looks like the h2/h3 are usually inside the page-section. Could we move them here as well? The h1 appears to always be outside. For comparison see patron form, patron details and patron import. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Sorry, for the confusion here Cait. I'll move these patches over to Bug 31820 and address the heading problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #6)
Sorry, for the confusion here Cait. I'll move these patches over to Bug 31820 and address the heading problem.
Please don't move, I fixed the descriptions and the patch is ok here now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142232|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142459&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142460&action=edit Bug 31837: (follow-up) Move page-section to include h2 headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This template needs an indentation cleanup.. rather confusing as it stands. More directly related.. I think perhaps each of the top columns should also be carded.. but that's not immediately trivial, as I just found.. so I'll open a new bug for that one.. Finally.. there's also a bug around the 'Managed by'.. the 'add user' is on the wrong side of the label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working on a follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142459|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142473&action=edit Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142460|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142474&action=edit Bug 31837: (follow-up) Move page-section to include h2 headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I gave up.. this template is a real mess. So.. passing QA as is and I'll raise a new bug for going through the template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 [Bug 31932] The basket summary page template needs a cleanup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837 Bug 31837 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org