[Bug 17572] New: Remove issue.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Bug ID: 17572 Summary: Remove issue.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57272&action=edit Bug 17572: Remove itemtype-related warnings from issue.t This patch makes t/db_dependent/Circulation/issue.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/issue.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57273&action=edit Bug 17572: (followup) Remove test's hardcoded values This patch makes the tests use t::lib::TestBuilder instead of hardcoding values. Test plan: - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: All tests return green with and without the patch - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57272|0 |1 is obsolete| | Attachment #57273|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57275&action=edit [SIGNED-OFF] Bug 17572: Remove itemtype-related warnings from issue.t This patch makes t/db_dependent/Circulation/issue.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/issue.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57276&action=edit [SIGNED-OFF] Bug 17572: (followup) Remove test's hardcoded values This patch makes the tests use t::lib::TestBuilder instead of hardcoding values. Test plan: - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: All tests return green with and without the patch - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57275|0 |1 is obsolete| | Attachment #57276|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57449&action=edit Bug 17572: Remove itemtype-related warnings from issue.t This patch makes t/db_dependent/Circulation/issue.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/issue.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57450&action=edit Bug 17572: (followup) Remove test's hardcoded values This patch makes the tests use t::lib::TestBuilder instead of hardcoding values. Test plan: - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: All tests return green with and without the patch - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57451&action=edit Bug 17572: [QA Follow-up] Cosmetic changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17572 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org