[Bug 10781] New: Remove C4::ILSDI::Utility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Bug ID: 10781 Summary: Remove C4::ILSDI::Utility Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: srdjan@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org C4::ILSDI::Utility is not really required. It contains only two routines: * BorrowerExists() which is not used * Availability(), used only in C4::ILSDI::Services I propose we move Availability() to C4::ILSDI::Services and remove C4::ILSDI::Utility -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 20620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20620&action=edit bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|oleonard@myacpl.org |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: bug_10781: Removed ILSDI::Utility /usr/share/koha/testclone/.git/rebase-apply/patch:43: tab in indent. my ($biblionumber, $status, $msg, $location) = _availability($id); warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... <stdin>:43: tab in indent. my ($biblionumber, $status, $msg, $location) = _availability($id); warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Removing t/ILSDI_Utility.t CONFLICT (modify/delete): C4/ILSDI/Utility.pm deleted in bug_10781: Removed ILSDI::Utility and modified in HEAD. Version HEAD of C4/ILSDI/Utility.pm left in tree. Auto-merging C4/ILSDI/Services.pm CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20620|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 21688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21688&action=edit bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-02 last check this| | --- Comment #4 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21688|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22402&action=edit bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22402|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 22725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22725&action=edit bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Severity|enhancement |minor --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Tested both functions with ilsdi.pl. Works fine. Code looks good to me. No complaints from qa tools. Moving from enh to bugfix. No string changes. Still looks like a candidate for 3.14. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Srdjan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org