[Bug 34418] New: Allow empty nodes in breadcrumb's elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Bug ID: 34418 Summary: Allow empty nodes in breadcrumb's elements Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 33169 On bug 33169 we rewrite the way we build the breadcrumb for the Vue app. It leads to a missing use case, see bug 33169 comment 27: """ 2. I am trying to adjust the code from bug 30708 to use this, but I am struggling. I don't know if it's me or this implementation that is not flexible enough. I am trying to have, in the breadcrumbs: /preservation/trains/3 => Preservation > Trains > Show train /preservation/trains/3/items/add => Preservation > Trains > Add item to train Ideally we will need to display the name of the current resource, but that's another topic. I don't think it's feasible for now (discussed already in comment 18 and comment 19). With my try on https://gitlab.com/joubu/Koha/-/commits/preservation_module-wip-33169 I am getting: /preservation/trains/3 => Preservation > Trains > Show train (OK) /preservation/trains/3/items/add => Preservation > Trains > Show train > > Add item to train (KO there are 2 '>') Additionally "Show train" is /preservation/trains/:train_id """ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 [Bug 33169] Improve vue breadcrumbs and left-hand menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153902&action=edit Bug 34418: DO NOT PUSH - example Try the other patch with this patch applied. Go to http://localhost:8081/cgi-bin/koha/erm/agreements/1/items/add Without the patch you get: E-resource management > Agreements > Show agreement > > Add item to train With this patch applied: E-resource management > Agreements > Show agreement > Add item to train -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153903&action=edit Bug 34418: Allow empty nodes in breadcrumb's elements Coming from an adaptation of "Bug 33169: DO NOT PUSH Allow breadcrumbs to accept dynamic values" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Matt, I am wondering if we should not have a flag in the route definition instead, we already have is_base, is_navigation_item, is_end_node and is_default. Shouldn't we have another one to flag this kind of node? Also it will clearly show in the routes that this node is always empty and can permit to catch bug more easily (Seeing the 2 "> >" in case it's empty but should not). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153904&action=edit Bug 34418: Add is_empty flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153905&action=edit Bug 34418: DO NOT PUSH - update example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153902|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153910&action=edit Bug 34418: DO NOT PUSH - example Try the other patch with this patch applied. Go to http://localhost:8081/cgi-bin/koha/erm/agreements/1/items/add Without the patch you get: E-resource management > Agreements > Show agreement > > Add item to train With this patch applied: E-resource management > Agreements > Show agreement > Add item to train -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153903|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153911&action=edit Bug 34418: Allow empty nodes in breadcrumb's elements Coming from an adaptation of "Bug 33169: DO NOT PUSH Allow breadcrumbs to accept dynamic values" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153904|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153912&action=edit Bug 34418: Add is_empty flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153905|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153913&action=edit Bug 34418: DO NOT PUSH - update example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #3)
Matt, I am wondering if we should not have a flag in the route definition instead, we already have is_base, is_navigation_item, is_end_node and is_default.
Shouldn't we have another one to flag this kind of node? Also it will clearly show in the routes that this node is always empty and can permit to catch bug more easily (Seeing the 2 "> >" in case it's empty but should not).
This is definitely cleaner! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 34425 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 153983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153983&action=edit Bug 34418: Replace dynamic parameter on unnamed route node -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #13 from Agustín Moyano <agustinmoyano@theke.io> --- The last patch I pushed is to fix the link when it has parameters, for example, the "/preservation/trains/:train_id" on the Show train breadcrumb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Agustín Moyano from comment #13)
The last patch I pushed is to fix the link when it has parameters, for example, the "/preservation/trains/:train_id" on the Show train breadcrumb
I am not sure to understand what this patch is trying to fix, could you provide more detail please? Does it apply to the ERM module as well? I have tried on the wip for the preservation module, and: Preservation > Trains > Show train > Add item to train I have "Show train" with /cgi-bin/koha/preservation/trains/1 With and without this last patch. I have adjusted the remote branch preservation_module-wip-33169 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #14)
(In reply to Agustín Moyano from comment #13)
The last patch I pushed is to fix the link when it has parameters, for example, the "/preservation/trains/:train_id" on the Show train breadcrumb
I am not sure to understand what this patch is trying to fix, could you provide more detail please?
Does it apply to the ERM module as well?
I have tried on the wip for the preservation module, and:
Preservation > Trains > Show train > Add item to train I have "Show train" with /cgi-bin/koha/preservation/trains/1
With and without this last patch.
I have adjusted the remote branch preservation_module-wip-33169
According to vue-router docs, "params are ignored if a path is provided, which is not the case for query, as shown in the example above. Instead, you need to provide the name of the route or manually specify the whole path with any parameter" That means that when we build the breadcrumb if in your routes tree you did not specify a name, NavigationItem will render the second choice <router-link v-else-if="item.path" :to="item.path" :class="{ disabled: item.disabled }"
Where item.path would be /preservation/trains/:train_id I did not check that branch, but if you added names to your router (as ERM has) this patch would have no effect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #16 from Agustín Moyano <agustinmoyano@theke.io> --- I see that you added 'name: "TrainsShow"' to the node, I believe that if you remove that name, you will see the difference with or without the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153983|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154095&action=edit Bug 34418: Replace dynamic parameter on unnamed route node Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Agustín Moyano from comment #16)
I see that you added 'name: "TrainsShow"' to the node, I believe that if you remove that name, you will see the difference with or without the patch
Ok, I see now. It's working great! For instance, when on: Preservation > Trains > Show train > Add item to train "Show train" is "preservation/trains/42" with this patch Without this patch is was "preservation/trains/:train_id". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 [Bug 30708] Creation of a new 'Preservation' module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153910|0 |1 is obsolete| | Attachment #153911|0 |1 is obsolete| | Attachment #153912|0 |1 is obsolete| | Attachment #153913|0 |1 is obsolete| | Attachment #154095|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154210&action=edit Bug 34418: DO NOT PUSH - example Try the other patch with this patch applied. Go to http://localhost:8081/cgi-bin/koha/erm/agreements/1/items/add Without the patch you get: E-resource management > Agreements > Show agreement > > Add item to train With this patch applied: E-resource management > Agreements > Show agreement > Add item to train Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154211&action=edit Bug 34418: Allow empty nodes in breadcrumb's elements Coming from an adaptation of "Bug 33169: DO NOT PUSH Allow breadcrumbs to accept dynamic values" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154212&action=edit Bug 34418: Add is_empty flag Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154213&action=edit Bug 34418: DO NOT PUSH - update example Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154214&action=edit Bug 34418: Replace dynamic parameter on unnamed route node Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Paul, we need you here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #24)
Paul, we need you here.
Sorry, wrong bug, it was 34417! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154210|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155098&action=edit Bug 34418: DO NOT PUSH - example Try the other patch with this patch applied. Go to http://localhost:8081/cgi-bin/koha/erm/agreements/1/items/add Without the patch you get: E-resource management > Agreements > Show agreement > > Add item to train With this patch applied: E-resource management > Agreements > Show agreement > Add item to train Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154211|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155099&action=edit Bug 34418: Allow empty nodes in breadcrumb's elements Coming from an adaptation of "Bug 33169: DO NOT PUSH Allow breadcrumbs to accept dynamic values" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154212|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155100&action=edit Bug 34418: Add is_empty flag Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154213|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155101&action=edit Bug 34418: DO NOT PUSH - update example Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154214|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155102&action=edit Bug 34418: Replace dynamic parameter on unnamed route node Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33169 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #32)
Depends on Bug 33169 not in 23.05.x
In the end Bug 33169 is backported. But since this is minor I propose to keep it that way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Bug 34418 depends on bug 33169, which changed state. Bug 33169 Summary: Improve vue breadcrumbs and left-hand menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org