[Bug 17605] New: EDI should set currency in order record on creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Bug ID: 17605 Summary: EDI should set currency in order record on creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org When creating an aqorder for a quote orderline currency is not explicitly set. The process should set it to the appropriate currency for the vendor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 57421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57421&action=edit Proposed patch Without the patch currency in created orders defaults to null - with patch they are set to the currency as specified in the vendor record for listprice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 57811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57811&action=edit Bug 17605 Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Attachment #57421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Signed off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that we have a Koha::Object for Bookseller(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #4)
Note that we have a Koha::Object for Bookseller(s)
By not using the Koha::Object this patch will apply to the stable banches 16.5 and 16.11 Booksellers.pm and hence the find method only present in master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Colin Campbell from comment #5)
(In reply to Marcel de Rooy from comment #4)
Note that we have a Koha::Object for Bookseller(s)
By not using the Koha::Object this patch will apply to the stable banches 16.5 and 16.11 Booksellers.pm and hence the find method only present in master
Agreed. Sounds reasonable for the stable branches. Since the patch only deals with two lines, you could also supply two versions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #7 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 61027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61027&action=edit Patch against master Previous version of patch required for 16.5 or 16.11 this version wraps the dbic calls in Koha::Object::Booksellers but requires dependencies currently only im master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #6)
(In reply to Colin Campbell from comment #5)
(In reply to Marcel de Rooy from comment #4)
Note that we have a Koha::Object for Bookseller(s)
By not using the Koha::Object this patch will apply to the stable banches 16.5 and 16.11 Booksellers.pm and hence the find method only present in master
Agreed. Sounds reasonable for the stable branches. Since the patch only deals with two lines, you could also supply two versions?
Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- They are exactly the same? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61027|0 |1 is obsolete| | --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 61028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61028&action=edit Patch against master oops uploaded wrong version - corrected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61029&action=edit Bug 17605: [MASTER] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61030&action=edit Bug 17605: [STABLE] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57811|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Signed Off |Passed QA --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing enhancement to normal. Stable patch is provided for stable branches.. Looks good to me. Just noting for the record that we do not have unit tests for Koha::EDI. Should not block this twoliner.. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed the MASTER one to master. should be in 17.05 ;) Thanks Note we still have a STABLE on to take care of -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed the [STABLE] patch. This patch has been pushed to 16.11.x and will be in 16.11.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17605 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #16 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org