[Bug 36824] New: Fix conversion of __VERSION__ in system preferences to use main rather than master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Bug ID: 36824 Summary: Fix conversion of __VERSION__ in system preferences to use main rather than master Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The descriptions of EmailFieldPrecedence and PatronSelfModificationMandatoryField have links to schema.koha-community.org which insert the running version into the URL. For development versions, those need to be inserting /main/ rather than /master/. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Well, a few more than just those two, counting is hard. Luckily, if one works they all work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 166480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166480&action=edit Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master Test plan: 1. Administration > search system preferences for the words database columns 2. Click the links to schema.koha-community.org, note that they 404 with /master/ in the URL 3. Apply patch, reset_all 4. Search again, click the links, note that they load successfully with /main/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166480|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 166482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166482&action=edit Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master Test plan: 1. Administration > search system preferences for the words database columns 2. Click the links to schema.koha-community.org, note that they 404 with /master/ in the URL 3. Apply patch, reset_all 4. Search again, click the links, note that they load successfully with /main/ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166482|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166533&action=edit Bug 36824: Fix conversion of __VERSION__ in system preferences to use main rather than master Test plan: 1. Administration > search system preferences for the words database columns 2. Click the links to schema.koha-community.org, note that they 404 with /master/ in the URL 3. Apply patch, reset_all 4. Search again, click the links, note that they load successfully with /main/ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for finding and fixing these, Phil! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from Aude Charillon <aude.charillon@ptfs-europe.com> --- No update to the Koha Manual needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org