[Bug 8995] New: Show OpenURL links in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Priority: P5 - low Change sponsored?: --- Bug ID: 8995 Assignee: julian.maurice@biblibre.com Summary: Show OpenURL links in OPAC search results Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13141&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes are made for UNIMARC and MARC21 xslt. Note: this patch also moves the Babeltheque code outside an if statement "if (C4::Context->preference('COinSinOPACResults'))" (was misplaced because Babeltheque don't need COinS) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |claire.hernandez@biblibre.c | |om --- Comment #2 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- We are currently working on this patch, please do not consider this submission for the moment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13141|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22753&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Sponsored by Rennes 2 university. This patch also clean the date taken from 210 field, because openurl standard does not accept dates like "impr. 2010" or "cop 2009". It needs only 2010 or 2009. I'm testing it. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Sorry, Software error: Can't escape \x{0152}, try uri_escape_utf8() instead at /home/msaby/kohamaster/src/C4/Biblio.pm line 1452. even with new syspref disabled. I suppose it is linked to the refactoring of COins. 2 questions : - now that we have a bootstrap opac defined as new default opac, does this patch needs a followup to work with bootstrap theme as well as with prog theme? - as the changes made on building COins could potentially have effects even if the new syspref is not activated (cf my software error...), I think we need a little regression test plan, to be sure Coins are still build correctly for unimarc and marc21 (I've seen things about 773 field, but I don't know what is it for). I'm not sure of the best way to do that : I suppose some FF extensions like OpenURLReferrer could be usefull for that, but I've not tested it recently... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22753|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 23625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23625&action=edit Bug 8995: Show OpenURL links in OPAC search results Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 23626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23626&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 23627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23627&action=edit Bug 8995: Show OpenURL links in bootstrap theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- 1st patch rebased on master 2nd patch fix the "Can't escape \x{0152}" error 3rd patch update bootstrap theme to display OpenURL links All patches needs a signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23625|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24087&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23626|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24088&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23627|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24089&action=edit Bug 8995: Show OpenURL links in bootstrap theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- rebased patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82@web.de --- Comment #14 from Holger Meißner <h.meissner.82@web.de> --- Applying: Bug 8995: Show OpenURL links in OPAC search results Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Auto-merging opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8995: Show OpenURL links in OPAC search results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24087|0 |1 is obsolete| | Attachment #24088|0 |1 is obsolete| | Attachment #24089|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26899&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26900&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26901&action=edit Bug 8995: Show OpenURL links in bootstrap theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #18 from David Cook <dcook@prosentient.com.au> --- I like this idea, but I imagine it might make more sense to have a system preference called "OPACOpenURLForItemTypes" rather than "OPACHideOpenURLForItemTypes". That is, I imagine there are probably only going to be maybe one or two item types (i.e. eJournals and maybe eBooks) where you want to provide a OpenURL. So rather than listing all the ones you don't, it would be easier and less ongoing maintenance, to just list the ones that you do want to include. -- It might also be an idea to change most of references to COinS to OpenURL in the code, since it really is OpenURL data being generated. The only time there really are COinS is when you stick the OpenURL into an HTML span, right? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #19 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Some problems occurred applying patches from bug 8995: <h1>Something went wrong !</h1>Applying: Bug 8995: Show OpenURL links in OPAC search results Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm Auto-merging C4/XSLT.pm CONFLICT (content): Merge conflict in C4/XSLT.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl Auto-merging opac/opac-detail.pl CONFLICT (content): Merge conflict in opac/opac-detail.pl Auto-merging opac/opac-search.pl Failed to merge in the changes. Patch failed at 0001 Bug 8995: Show OpenURL links in OPAC search results When you have -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #20 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I'm really interested in this functionality. Are you still working on it ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26899|0 |1 is obsolete| | Attachment #26900|0 |1 is obsolete| | Attachment #26901|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29357&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29358&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29359&action=edit Bug 8995: Show OpenURL links in bootstrap theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- I just fixed the conflicts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #25 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I'm disappointed, because I made a lot of tests and everything is OK except I can't see the openurl link when I Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default". It works very well when this sysprefs are empty (tested with two different open resolvers with electronic journals and ebooks.) Two more remarks : I agree with David Cook (Comment 18) : we usually use open url for 2 item types, it would be easier to list only those two and not all the others. It is possible to open the link in a new tab (I activate the syspref OPACOpenInNewWindow, but there is no difference) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #26 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- One detail : I have tested only with the bootstrap theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29357|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30385&action=edit Bug 8995: Show OpenURL links in OPAC search results Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29358|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30386&action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29359|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30387&action=edit Bug 8995: Show OpenURL links in bootstrap theme Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30388&action=edit Bug 8995: Add OpenURL link to OPAC bootstrap XSLT files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30389&action=edit Bug 8995: Change meaning and name of syspref OPACHideOpenURLForItemTypes OPACHideOpenURLForItemTypes is now named OPACOpenURLItemTypes and do the exact opposite as before: it shows OpenURL link only if the biblio itemtype is in the syspref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #25)
I'm disappointed, because I made a lot of tests and everything is OK except I can't see the openurl link when I Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default". It works very well when this sysprefs are empty (tested with two different open resolvers with electronic journals and ebooks.)
Fixed by attachment 30388
Two more remarks : I agree with David Cook (Comment 18) : we usually use open url for 2 item types, it would be easier to list only those two and not all the others.
Fixed by attachment 30389 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> ---
It is possible to open the link in a new tab (I activate the syspref OPACOpenInNewWindow, but there is no difference)
I wasn't aware of OpacOpenInNewWindow syspref, I will take a look to see what I can do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30390&action=edit Bug 8995: Consider OPACURLOpenInNewWindow for OpenURL links -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi@cineca.it --- Comment #35 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patches aginst master 3.17.00.055 Applying: Bug 8995: Show OpenURL links in OPAC search results Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt deleted in HEAD and modified in Bug 8995: Show OpenURL links in OPAC search results. Version Bug 8995: Show OpenURL links in OPAC search results of koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree. CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt deleted in HEAD and modified in Bug 8995: Show OpenURL links in OPAC search results. Version Bug 8995: Show OpenURL links in OPAC search results of koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree. Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/XSLT.pm CONFLICT (content): Merge conflict in C4/XSLT.pm Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8995: Show OpenURL links in OPAC search results So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30385|0 |1 is obsolete| | Attachment #30386|0 |1 is obsolete| | Attachment #30387|0 |1 is obsolete| | Attachment #30388|0 |1 is obsolete| | Attachment #30389|0 |1 is obsolete| | Attachment #30390|0 |1 is obsolete| | --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35747&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased and squashed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35747|0 |1 is obsolete| | --- Comment #38 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35916&action=edit [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results The new sysprefs are 5: NB - OPACShowOpenURL: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link NB - OPACOpenURLItemTypes: List of item type codes (separated by spaces) for those you want to show the OpenURL link Link is displayed as an image if OpenURLImageLocation is defined. Link is displayed as an text if OpenURLText is defined. If neither OpenURLImageLocation nor OpenURLText are defined, link is displayed as the text "OpenURL". If either OpenURLImageLocation or OpenURLText are defined, link is displayed as an image whose title-text is the OpenURLText text. I've applied the patch against master 3.19.00.011 The patch contains "3.17.00" and needs to be rebased trivially. Soon after upgrading, and having set the sysprefs to enable OpenURL, I re-indexed zebra. Everything is OK as required. So I pass the patch to "Signed OFF" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch conflicts in a since removed CSS file: CONFLICT (modify/delete): koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css Looking at the patch I can see that the .less file for bootstrap has been modified, but there is no updated generated CSS file, but only the change to the outdated file. Can you check please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35916|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40647&action=edit [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results Rebased on master + updated generated CSS file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some conflicts - especially in the CSS files. Please fix! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8995: Show OpenURL links in OPAC search results Using index info to reconstruct a base tree... M C4/Biblio.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref M koha-tmpl/opac-tmpl/bootstrap/css/opac.css M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl M koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl M koha-tmpl/opac-tmpl/bootstrap/less/opac.less M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/less/opac.less CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/less/opac.less Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8995: Show OpenURL links in OPAC search results The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-8995-Show-OpenURL-links-in-OPAC-sea-AHeoX5.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40647|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44639&action=edit [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results Rebased on master updatedatabase entry moved into atomicupdate/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 44639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44639 [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results Review of attachment 44639: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8995&attachment=44639) ----------------------------------------------------------------- Hi, I have started with a code review here: 1) Please remove the changes to opac-detail.tt and opac-results.tt. (see: http://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-XSLT_search...) ::: C4/XSLT.pm @@ +215,5 @@
$sysxml .= "<syspref name=\"$syspref\">$sp</syspref>\n"; } $sysxml .= "</sysprefs>\n"; + + $variables ||= {};
2) Please chose a better variable name reflecting that this is about the OpenUrl feature. ::: installer/data/mysql/sysprefs.sql @@ +510,1 @@
;
2.5) Please do the librarian in me a favor... and keep the alphabetic order in this file :) ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ +324,4 @@
both: "both top and footer" top: "top" footer: "only footer" + -
3) Please create a new heading for the OpenURL preferences, so that they are listed in one section together. @@ +324,5 @@
both: "both top and footer" top: "top" footer: "only footer" + - + - 'Complete URL of OpenURL resolver (starting with <tt>http://</tt> or <tt>https://</tt>):'
4) Please remove the <tt> tags (see: https://www.w3.org/wiki/HTML/Elements/tt). I think we are using <code> in some other preferences. @@ +349,5 @@
+ - + - 'List of item type codes (separated by spaces) for those you want to show the OpenURL link:' + - pref: OPACOpenURLItemTypes + - '<br />' + - 'It uses biblioitems.itemtype field, so if you map a MARC field to it, and link this MARC field to a list of authorised values (for example CCODE), you can use these values for system preference value.'
5) Sorry, but I think this is bad advice. One shouldn't redefine the biblioitems.itemtype field like that - or you will cause yourself trouble in a lot of other places. For example some of the circulation code falls back to the itemtype defined on biblio level now. What happens when pref is left empty? Can the OpenUrl be displayed for records with empty biblioitems.itemtype? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Are there still plans to get this moving again? Additional question: How is this related to the COinS html Koha already generates? Why do we exactly need this, if that span can be easily converted to an OpenURL with standard solutions (browser extensions etc.) ? http://ocoins.info/latent.html -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org