[Bug 5263] New: Add support for including fields from the ISSUES table in advanced due notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Summary: Add support for including fields from the ISSUES table in advanced due notices Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Notices AssignedTo: henridamien@koha-fr.org ReportedBy: cnighswonger@foundations.edu QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Add support for including fields from the Issues table in advanced due notices. This is primarily to allow the inclusion of the due date for each item in the advanced due notice, but will allow the inclusion of any field from the ISSUES table. This also adds code to exclude timestamp fields as these are irrelevant to the end user in this context. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |P1 Estimated Hours|0.0 |1.0 AssignedTo|henridamien@koha-fr.org |cnighswonger@foundations.ed | |u -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Hours Worked| |1 Priority|P1 |PATCH-Sent Status|NEW |ASSIGNED --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-09-29 13:41:01 UTC --- Related patches can be picked up here: http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=shortlog;h=refs/h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Does not apply --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-03-08 00:28:48 UTC --- Does not apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5263 - Add support for including fields from the ISSUES table in advanced due notices Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm Auto-merging tools/letter.pl Failed to merge in the changes. Patch failed at 0001 Bug 5263 - Add support for including fields from the ISSUES table in advanced due notices When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-07 22:18:52 UTC --- Created attachment 4583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4583 Bug 5263 - Add support for including fields from the ISSUES table in advanced due notices Adding support for including fields from the Issues table in advanced due notices. This is primarily to allow the inclusion of the due date for each item in the advanced due notice, but will allow the inclusion of any field from the ISSUES table. This also adds code to exclude timestamp fields as these are irrelevant to the end user in this context. Note: Documentation should be updated to reflect the availability of the additional fields in all circulation notices. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-07-08 17:48:00 UTC --- The patch applies and the fields are available, but I added the due date and the issuedate to the checkout notice and instead of values showing I saw <> and <> for the two values I tried to add. Is there another way to test this? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-17 21:42:45 UTC --- I checked both PREDUE and PREDUEDGST with following results: PREDUE notice: borrowernumber <<issues.borrowernumber>> itemnumber <<issues.itemnumber>> date_due <<issues.date_due>> branchcode <<issues.branchcode>> issuingbranch <<issues.issuingbranch>> returndate <<issues.returndate>> lastrenewddate <<issues.lastreneweddate>> return <<issues.return>> renewals <<issues.renewals>> issuedate <<issues.issuedate>> PREDUE result: borrowernumber 19 itemnumber 8 date_due 2011-07-18 branchcode MPL issuingbranch returndate lastrnewddate return renewals issuedate 2011-07-17 RESULT: OK - Improvement, but date formatting is wrong. PREDUEDGST: <<items.content>> ./misc/cronjobs/advance_notices.pl -i date_due,branchcode,itemnumber,borrowernumber,issuedate PREDUEDGST: 07/18/2011 MPL 8 19 07/17/2011 RESULT: OK - Date formatting is correct too. I am signing off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4583|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-17 21:44:37 UTC --- Created attachment 4648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4648 [SIGNED-OFF] Bug 5263 - Add support for including fields from the ISSUES table in advanced due notices Adding support for including fields from the Issues table in advanced due notices. This is primarily to allow the inclusion of the due date for each item in the advanced due notice, but will allow the inclusion of any field from the ISSUES table. This also adds code to exclude timestamp fields as these are irrelevant to the end user in this context. Note: Documentation should be updated to reflect the availability of the additional fields in all circulation notices. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-02 01:01:17 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Patch Pushed |Failed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-03 14:42:30 UTC --- This patch has the items table being parsed with biblionumber as Key, which will result in all item information being wrong, unless itemnumber happens to equal biblionumber. Marking this as Failed QA, though it's a little late. I'll work on the fix and submit as a followup. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 --- Comment #9 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-03 14:50:51 UTC --- Created attachment 5678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5678 Follow up Patch Fixes the issue introduced by the original patch of the items table being keyed in using the biblionumber -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5263 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-03 19:55:29 UTC --- Pushed the follow up, please test again -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org