https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48721&action=edit Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch uses a "trash" icon for delete: <i class="fa fa-trash"></i> ...while other use the "remove" icon (an X): <i class="fa fa-remove"></i> We need to pick one and standardize on it. Perhaps the trash icon is more correct even if it is currently less common in the templates. Use it for "delete" and use the X in cases where we mean "cancel?" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- % git grep Delete | grep fa-trash|wc 11 156 3712 % git grep Delete | grep fa-remove|wc 16 220 4297 I also prefer the trash icon for the deletion. I have just QAed several patches using the trash icons, so let's move fa-remove to fa-trash in another bug report? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48827|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48851&action=edit Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.