[Bug 29464] New: Sorting broken for receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Bug ID: 29464 Summary: Sorting broken for receiving in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This seems to be from bug 20212 - the sort options in the headers of the pending_orders table no longer function. Additionally, the 'Summary' column is now marked as 'orderable: false' - it was possible to sort on this column before those patches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Improve performance of acquisitions receive page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed the issue :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Bug 29464 depends on bug 20212, which changed state. Bug 20212 Summary: Improve performance of acquisitions receive page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 29570 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This was certainly working on bug 20212. Will try to check what else changed after it was pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sorting broken for |GET /acquisitions/orders |receiving in acquisitions |doesn't honour sorting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128395&action=edit Bug 29464: Regression tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128396&action=edit Bug 29464: Make GET /acquisitions/orders honour sorting When bug 20212 was pushed, we lost (didn't dig enough to find out how) the sorting feature for this route. This is mainly because biblio+biblioitems filtering prevents the route to use plain $c->objects->search, so it has baked a custom version of it. In this case, it missed the call to the dbic_merge_sorting helper, that takes care of reading the query parameters and inject the sorting attributes to the resultset. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, sorting doesn't actually work 3. Apply this patch 4. Repeat 2 => SUCCESS: Sorting works! 5. Test sorting the pending orders on parcel.tt 6. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #0)
This seems to be from bug 20212 - the sort options in the headers of the pending_orders table no longer function.
Done.
Additionally, the 'Summary' column is now marked as 'orderable: false' - it was possible to sort on this column before those patches
Will handle this on bug 29570. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128395|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128397&action=edit Bug 29464: Regression tests Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128396|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128398&action=edit Bug 29464: Make GET /acquisitions/orders honour sorting When bug 20212 was pushed, we lost (didn't dig enough to find out how) the sorting feature for this route. This is mainly because biblio+biblioitems filtering prevents the route to use plain $c->objects->search, so it has baked a custom version of it. In this case, it missed the call to the dbic_merge_sorting helper, that takes care of reading the query parameters and inject the sorting attributes to the resultset. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, sorting doesn't actually work 3. Apply this patch 4. Repeat 2 => SUCCESS: Sorting works! 5. Test sorting the pending orders on parcel.tt 6. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Tests pass and sorting works so I signed off. Making the Summary/title sortable again will happen in Bug 29570? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Lucas Gass from comment #9)
Tests pass and sorting works so I signed off. Making the Summary/title sortable again will happen in Bug 29570?
Yes, that's much more complex to solve. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 29570 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.ingram@cedarparkt | |exas.gov --- Comment #12 from Catherine E. Ingram <catherine.ingram@cedarparktexas.gov> --- This is a bug that is costing my staff time every day. If we receive an order of 30 books and have to go into Acquisitions and click "received" on each title - it is much easy to find the titles when they are in alphabetical order. Otherwise it is a hunt and seek when the titles are listed in random order. So it might take anywhere from a few extra minutes for a small order to an extra 10 minutes for a larger order. Thank you, Catherine Ingram -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #13 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- +1 It has negatively impacted our workflow as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #10)
(In reply to Lucas Gass from comment #9)
Tests pass and sorting works so I signed off. Making the Summary/title sortable again will happen in Bug 29570?
Yes, that's much more complex to solve.
(In reply to Tomás Cohen Arazi from comment #11)
*** Bug 29570 has been marked as a duplicate of this bug. ***
Why is this marked as duplicate? We are not solving the problem for the summary column (and so the sort by title) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #14)
(In reply to Tomás Cohen Arazi from comment #10)
(In reply to Lucas Gass from comment #9)
Tests pass and sorting works so I signed off. Making the Summary/title sortable again will happen in Bug 29570?
Yes, that's much more complex to solve.
(In reply to Tomás Cohen Arazi from comment #11)
*** Bug 29570 has been marked as a duplicate of this bug. ***
Why is this marked as duplicate? We are not solving the problem for the summary column (and so the sort by title)
duplicate status has been reverted, I missed that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128397|0 |1 is obsolete| | Attachment #128398|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129136&action=edit Bug 29464: Regression tests Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129137&action=edit Bug 29464: Make GET /acquisitions/orders honour sorting When bug 20212 was pushed, we lost (didn't dig enough to find out how) the sorting feature for this route. This is mainly because biblio+biblioitems filtering prevents the route to use plain $c->objects->search, so it has baked a custom version of it. In this case, it missed the call to the dbic_merge_sorting helper, that takes care of reading the query parameters and inject the sorting attributes to the resultset. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, sorting doesn't actually work 3. Apply this patch 4. Repeat 2 => SUCCESS: Sorting works! 5. Test sorting the pending orders on parcel.tt 6. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- This is quite a pain point for many libraries, is there a chance to get this one backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updating severity a little and also +1 for backporting :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.05.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00,21.05.09 |22.05.00,21.05.09,21.11.03 released in| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org