[Bug 28014] New: Add table settings to batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Bug ID: 28014 Summary: Add table settings to batch patron modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org It would be useful to be able to configure table settings for the preview and results of batch patron modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118610&action=edit Bug 28014: Add table settings to batch patron modification This patch adds table settings to the tables shown before and after a batch of patrons has been submitted for batch patron modification. To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118610|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118669&action=edit Bug 28014: Add table settings to batch patron modification To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118669|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118912&action=edit Bug 28014: Add table settings to batch patron modification This patch adds table settings to the tables shown before and after a batch of patrons has been submitted for batch patron modification. To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Depends on| |28007 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please rebase on top of bug 28007. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28007 [Bug 28007] Replace obsolete title-string sorting: Tools templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118912|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119419&action=edit Bug 28014: Add table settings to batch patron modification This patch adds table settings to the tables shown before and after a batch of patrons has been submitted for batch patron modification. To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds DataTable release notes| |table configuration and | |export options to the table | |of patrons submitted for | |batch modification, both | |before and after | |modifications are made. The | |table will now be | |configurable via Table | |Settings in Administration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not directly related to this (I think), but I found something: The NoSort is not taken into account (the first column, the checkboxes, is sortable). It could have been caused by bug 28055, but not sure I understand the problem correctly. Reverting the following changes seem to fix the problem: - if ( new_parameters["aoColumnDefs"] === undefined ) { - new_parameters["aoColumnDefs"] = default_column_defs; + if ( new_parameters["columnDefs"] === undefined ) { + new_parameters["columnDefs"] = default_column_defs; Owen, could you have a look please (certainly need to be fixed as a follow-up of bug 28055 if the assertion is correct)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- You're correct Jonathan, the changes to columns_settings.inc adversely affect several pages which still use the old "aoColumnDefs" option. Those particular lines should be only be converted to use "columnDefs" if the patch includes changes to those other files at the same time. Would you prefer the follow-up here or on Bug 28055? Or a new bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A follow-up on bug 28055 would be perfect! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 28007 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 [Bug 30628] Batch borrower modifications only affect the current page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org