[Bug 27623] New: Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Bug ID: 27623 Summary: Remove pl-PL installer data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: bgkriegel@gmail.com, gmcharlt@gmail.com, jonathan.druart@bugs.koha-community.org, katrin.fischer@bsz-bw.de, koha-bugs@lists.koha-community.org, lucas@bywatersolutions.com, martin.renvoize@ptfs-europe.com, testopia@bugs.koha-community.org, victor@tuxayo.net Depends on: 24973, 24871 Now we can translate all installer data, then the pl-PL directory is no longer needed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 [Bug 24871] Add new *-installer-*.po translation files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 [Bug 24973] Allow to localize and translate system preferences with new yaml based installer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://gitlab.com/joubu/Koha/-/tree/bug_27623 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've worked through the patch and it makes sense to me.. Signing off (Will leave Jonathan to add the SO line to the branch) -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the SQL release notes| |installer directory from | |the Koha source code. | |Installing Polish sample | |data will still be | |possible, but translations | |have been moved into Koha's | |translation system using | |.po files maintained on | |https://translate.koha-comm | |unity.org. URL| |https://gitlab.com/joubu/Ko | |ha/-/tree/bug_27623 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- pl-PL appears to be a mostly untranslated copy of the English files. I think the only thing we should think about for a custom.sql here is active currency and adding PLN. -INSERT INTO `currency` (currency, rate, symbol, active) VALUES -('PLN', 1.0, 'zł', '1'), -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Missing change to xt/sample_notices.t -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Added Martin's signed-off-by line to the first commit, Added 2 new commits: Bug 27623: Fix sample_notices.t Bug 27623: Add PLN currency to custom.sql -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |joonas.kylmala@helsinki.fi --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Doesn't apply anymore -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #7 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #6)
Doesn't apply anymore
It was actually easy to fix this rebase issue:
git rm installer/data/mysql/pl-PL/mandatory/sample_notices.sql git am --continue
However, in the installer I get
Cannot decode string with wide characters at /usr/lib/x86_64-linux-gnu/perl> /5.24/Encode.pm line 202 in Encode::decode at /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 202
and also if following the test plan I get:
$ ./translate update pl-PL misc/translator/Koha-pref.pot:5085:37: invalid multibyte sequence
not sure if caused by this change or it got broken already before, but it makes testing this patch not possible. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #7)
(In reply to Joonas Kylmälä from comment #6)
Doesn't apply anymore
It was actually easy to fix this rebase issue:
git rm installer/data/mysql/pl-PL/mandatory/sample_notices.sql git am --continue
However, in the installer I get
Cannot decode string with wide characters at /usr/lib/x86_64-linux-gnu/perl> /5.24/Encode.pm line 202 in Encode::decode at /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 202
Which step, I didn't recreate that.
and also if following the test plan I get:
$ ./translate update pl-PL misc/translator/Koha-pref.pot:5085:37: invalid multibyte sequence
not sure if caused by this change or it got broken already before, but it makes testing this patch not possible.
I am seeing that Looks like it has been caused by bug 22824. I am investigating it. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 [Bug 28154] Translate script faces encoding issues -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #9 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Jonathan Druart from comment #8)
(In reply to Joonas Kylmälä from comment #7)
Which step, I didn't recreate that.
First run following commands:
$ koha-mysql kohadev < installer/data/mysql/kohastructure.sql $ ./translate install pl-PL
Then open the installer and select pl-PL as the language, then after few pages the error happens after clicking OK in the MARC21/UNIMARC selection page: http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=choosemarc -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should have been fixed by bug 28154. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Joonas, Katrin, can I get a QA stamp please? -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #12 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Jonathan Druart from comment #11)
Joonas, Katrin, can I get a QA stamp please?
Still the same problem with installer so cannot test this. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Still the same problem with installer so cannot test this.
Odd, I was able to complete the installer with the branch directly and with a rebase on master. Env: koha-testing-docker Note, there is a conflict when rebasing. Some recent commits modified one of the deleted files. So their changes might need to be moved somewhere (if these changes are still needed) -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rechecked, seems there is no issue => signed off! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #15 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Victor what were the exact steps you used, I still get the error, I even deleted koha-testing-docker (Debian GNU/Linux 9 version) completely and re-created it from scratch and I still get the error after: $ koha-mysql kohadev < installer/data/mysql/kohastructure.sql $ restart_all $ ./translate update pl-PL $ ./translate install pl-PL $ restart_all --> Go to installer page and select pl-PL as installer language, click through it and notice it gives error:
Cannot decode string with wide characters at /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 202
in the MARC21 step. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #16 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I found the cause and opened bug 28281. I will work on a fix (or I already have but missing test). -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #17 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I'm still unable to test this even after bug 28281 because misc/translator/LangInstaller.pm / ./translate script double *encodes* the output of installer/data/mysql/pl-PL/marcflavour/marc21/mandatory/authorities_normal_marc21.yml I tried to now change it like this: - open(my $fh, ">:encoding(UTF-8)", "$intradir/$tdir/$file"); - YAML::XS::DumpFile( $fh, $translated_yaml ); - close($fh); but that still produces broken UTF-8 in the file: installer/data/mysql/pl-PL/marcflavour/marc21/mandatory/authorities_normal_marc21.yml NOTE: Please be careful and remember to use "git clean -d -f" and git reset --hard HEAD before testing this bug. Otherwise the ./translate script doesn't update the translation files. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #18 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #17)
I tried to now change it like this:
- open(my $fh, ">:encoding(UTF-8)", "$intradir/$tdir/$file"); - YAML::XS::DumpFile( $fh, $translated_yaml ); - close($fh);
err, missed the "+" part of the diff, I made it to look like: + YAML::XS::DumpFile( "$intradir/$tdir/$file", $translated_yaml ); -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #19 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- ah, there is even a third bug! I have a fix now for that as well, will open new bug report and make this depends on that. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28291 [Bug 28291] koha-translate install script producing incorrectly encoded YAML translation files -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #20 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I have now fix for that as well in bug 28291 but tests still missing... -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Retried, still works after bug 28291 and bug 28281 :) -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this might be the same problem Victor already saw, but using the branch, I got stuck at this: YAML::XS::Load Error: The problem: control characters are not allowed was found at document: 0 at /usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/XS.pm line 51 in YAML::XS::LoadFile at /usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/XS.pm line 51 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Trying again with 28281 applied as well, but got stuck with the same error again :( Help? -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #22)
Hm, this might be the same problem Victor already saw, but using the branch,
Which problem? It seems I didn't get a problem each time I tried. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #25 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Katrin Fischer from comment #23)
Trying again with 28281 applied as well, but got stuck with the same error again :(
Help?
You need to have all those dependencies listed in the bug report here, not just 28281. Rebasing the patches on top of master is your best bet I think, it contains already those. But note I have not yet tried if it works still even after all those fixes because I have not yet went through the full installer after those bugs being fixed. Also please make sure to run "git clean -d -f" after your testing to make sure the translation files get updated. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Joonas Kylmälä from comment #25)
(In reply to Katrin Fischer from comment #23)
Trying again with 28281 applied as well, but got stuck with the same error again :(
Help?
You need to have all those dependencies listed in the bug report here, not just 28281. Rebasing the patches on top of master is your best bet I think, it contains already those. But note I have not yet tried if it works still even after all those fixes because I have not yet went through the full installer after those bugs being fixed. Also please make sure to run "git clean -d -f" after your testing to make sure the translation files get updated.
I've run the translation, but was probably missing other dependencies as you suggest. As this is on a branch, I think it'd be easier to have Joubu rebase as I can't attach a fixed patch set. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remote branch rebased against master. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |joonas.kylmala@helsinki.fi |y.org | --- Comment #28 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Passing QA: Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org