[Bug 39998] New: Missing presentation role on layout tables.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Bug ID: 39998 Summary: Missing presentation role on layout tables. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: nina.martinez@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org When tables are used for layout purposes, we should add the WAI-ARIA presentation role attributes. Misinterpreting layout tables as data tables can confuse users who rely on assistive technologies. For example, a screen reader will interpret the element as a data table and announce the number of rows and columns and the content inside. By adding role=”presentation”, the screen reader will just read the elements making the content more accessible and easier to understand, without unnecessary information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nina.martinez@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 --- Comment #1 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 182801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182801&action=edit Bug 39998: Add presentation role to the layout tables. This patch improves the accessibility of the OPAC. It's a trivial patch to help assistive technologies understand the different tables. Test plan: Enable the system preferences: OPACShelfBrowser, OPACPrivacy, ShowComponentRecords. 1- On the Koha OPAC, Research a record. 2- Inspect the result page HTML and notice that there is a role='presentation' in the table tag. 3- Choose a record with a Component section and inspect the HTML, there should be a role='presentation' in the table tag. 4- Open the Browse shelf. Inspect the HTML and notice that there is a role='presentation' in the table tag of the browse shelf. 5- Log in to a patron account, go to the Your Summary page, and choose Privacy in the menu. 6- Inspect the HTML of the page and notice that there is a role='presentation' in the table tag of the 'Immediate deletion'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182801|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183284&action=edit Bug 39998: Add presentation role to the layout tables. This patch improves the accessibility of the OPAC. It's a trivial patch to help assistive technologies understand the different tables. Test plan: Enable the system preferences: OPACShelfBrowser, OPACPrivacy, ShowComponentRecords. 1- On the Koha OPAC, Research a record. 2- Inspect the result page HTML and notice that there is a role='presentation' in the table tag. 3- Choose a record with a Component section and inspect the HTML, there should be a role='presentation' in the table tag. 4- Open the Browse shelf. Inspect the HTML and notice that there is a role='presentation' in the table tag of the browse shelf. 5- Log in to a patron account, go to the Your Summary page, and choose Privacy in the menu. 6- Inspect the HTML of the page and notice that there is a role='presentation' in the table tag of the 'Immediate deletion'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Status|Needs Signoff |Signed Off Version|unspecified |Main --- Comment #3 from Owen Leonard <oleonard@myacpl.org> ---
3- Choose a record with a Component section and inspect the HTML, there should be a role='presentation' in the table tag.
Bug 11175 has a sample record for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40221 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183284|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184661&action=edit Bug 39998: Add presentation role to the layout tables. This patch improves the accessibility of the OPAC. It's a trivial patch to help assistive technologies understand the different tables. Test plan: Enable the system preferences: OPACShelfBrowser, OPACPrivacy, ShowComponentRecords. 1- On the Koha OPAC, Research a record. 2- Inspect the result page HTML and notice that there is a role='presentation' in the table tag. 3- Choose a record with a Component section and inspect the HTML, there should be a role='presentation' in the table tag. 4- Open the Browse shelf. Inspect the HTML and notice that there is a role='presentation' in the table tag of the browse shelf. 5- Log in to a patron account, go to the Your Summary page, and choose Privacy in the menu. 6- Inspect the HTML of the page and notice that there is a role='presentation' in the table tag of the 'Immediate deletion'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: <table class="table" role="presentation "> There is a space at end of attribute, not cached by QA script ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39998 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org