[Bug 29737] New: Cannot suspend holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Bug ID: 29737 Summary: Cannot suspend holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Hold requests Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com
From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there.
There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128754&action=edit Bug 29737: Fix suspend from hold list
From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there.
There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128755&action=edit Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is a regression but no idea when it has been introduced! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128754|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 128780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128780&action=edit Bug 29737: Fix suspend from hold list
From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there.
There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128755|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 128781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128781&action=edit Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128780|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128803&action=edit Bug 29737: Fix suspend from hold list
From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there.
There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128781|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128804&action=edit Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com Resolution|--- |FIXED --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Cannot recreate issue on 21.05.x. Not backporting. Please request if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org