[Bug 11928] New: table aqorderdelivery seem useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Bug ID: 11928 Summary: table aqorderdelivery seem useless Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: z.tajoli@cineca.it QA Contact: testopia@bugs.koha-community.org Hi to all, it seem that the table 'aqorderdelivery' is not used in Koha now. No bugs if I search with 'aqorderdelivery'. If I search in the code the result is: koha@lctest:~/master$ grep -r -i 'aqorderdelivery' * installer/data/mysql/kohastructure.sql:-- Table structure for table `aqorderdelivery` installer/data/mysql/kohastructure.sql:DROP TABLE IF EXISTS `aqorderdelivery`; installer/data/mysql/kohastructure.sql:CREATE TABLE `aqorderdelivery` ( installer/data/mysql/update22to30.pl: aqorderdelivery => [ INSTALL.fedora7:| aqorderdelivery | Koha/Schema/Result/Aqorderdelivery.pm:package Koha::Schema::Result::Aqorderdelivery; Koha/Schema/Result/Aqorderdelivery.pm:Koha::Schema::Result::Aqorderdelivery Koha/Schema/Result/Aqorderdelivery.pm:=head1 TABLE: C<aqorderdelivery> Koha/Schema/Result/Aqorderdelivery.pm:__PACKAGE__->table("aqorderdelivery"); so no used. The table seems inserted in 2009 but never used. I think it could be deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26194&action=edit Bug 11928 - Remove unused table Aqorderdelivery has apparently never been used. This patch removes it. TEST PLAN --------- 1) Apply patch. 2) Confirm table is there. 3) Run upgrade process. 4) Confirm table has been removed. 5) Drop koha database and create empty one. 6) Fresh install from staff client. 7) Confirm table was not created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26194|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26196&action=edit Bug 11928 - Remove unused table Aqorderdelivery has apparently never been used. This patch removes it. TEST PLAN --------- 1) Apply patch. 2) Run the Koha QA Test tool. 3) Confirm table is there. 4) Run upgrade process. 5) Confirm table has been removed. 6) Drop koha database and create empty one. 7) Fresh install from staff client. 8) Confirm table was not created. 9) I'm unsure how to test the Schema's. It was just git rm'd. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- I agree that it is unused, and here is a patch to remove it. I decided against modifying update22to30.pl, so as to maintain continuity of upgrade paths taken by others in the past. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26196|0 |1 is obsolete| | --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 26218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26218&action=edit Bug 11928 - Remove unused table aqorderdelivery Aqorderdelivery has apparently never been used. This patch removes it. TEST PLAN --------- 1) Apply patch. 2) Run the Koha QA Test tool. 3) Confirm table is there. 4) Run upgrade process. 5) Confirm table has been removed. 6) Drop koha database and create empty one. 7) Fresh install from staff client. 8) Confirm table was not created. 9) I'm unsure how to test the Schema's. It was just git rm'd. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26218|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26240&action=edit Bug 11928 - Remove unused table aqorderdelivery Aqorderdelivery has apparently never been used. This patch removes it. TEST PLAN --------- 1) Apply patch. 2) Run the Koha QA Test tool. 3) Confirm table is there. 4) Run upgrade process. 5) Confirm table has been removed. 6) Drop koha database and create empty one. 7) Fresh install from staff client. 8) Confirm table was not created. 9) I'm unsure how to test the Schema's. It was just git rm'd. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11928 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolyn.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This is a cleanup, not really useful for stable branches. I set as resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org