[Bug 33938] New: Installer wants to upgrade even when the DB is up-to-date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 Bug ID: 33938 Summary: Installer wants to upgrade even when the DB is up-to-date Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org If you hit /cgi-bin/koha/installer/install.pl and that the DB is up-to-date already, the screen shows "We are upgrading from Koha 23.06.00.002 to 23.06.00.002" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152098&action=edit Bug 33938: Don't tell the DB is not up-to-date when it is If you hit /cgi-bin/koha/installer/install.pl and that the DB is up-to-date already, the screen shows "We are upgrading from Koha 23.06.00.002 to 23.06.00.002". We should just say that everything is ok Test plan: Have an up-to-date DB, then hit /cgi-bin/koha/installer/install.pl Notice that the message changed and is more correct with the patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152098|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152232&action=edit Bug 33938: Don't tell the DB is not up-to-date when it is If you hit /cgi-bin/koha/installer/install.pl and that the DB is up-to-date already, the screen shows "We are upgrading from Koha 23.06.00.002 to 23.06.00.002". We should just say that everything is ok Test plan: Have an up-to-date DB, then hit /cgi-bin/koha/installer/install.pl Notice that the message changed and is more correct with the patch applied. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- This feels wrong to me. We shouldn't have the comparison check in the templates. It should be in the controller script. Also, it doesn't take into account atomic updates. I'd raised bug 34088 to handle this scenario for updatedatabase.pl but hadn't gotten around to install.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #3)
This feels wrong to me. We shouldn't have the comparison check in the templates. It should be in the controller script.
Are you suggesting to make the comparison in the pl then pass a variable 'needs_upgrade' if dbversion != kohaversion? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If I hit this URL, I need to login first with the admin user to discover that the version is the same. We could do better than that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)
Are you suggesting to make the comparison in the pl then pass a variable 'needs_upgrade' if dbversion != kohaversion?
Well, there is already an "upgrading" variable which seems to be set without checking that upgrading is necessary. I think that we should fix it there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #5)
If I hit this URL, I need to login first with the admin user to discover that the version is the same. We could do better than that?
That's a good point too. Near the top of install.pl, we could do an upgrade check (I'd suggest the one from bug 34088) and if an upgrade isn't required, redirect to mainpage.pl. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org