[Bug 28730] New: Add option to format AH field (due date) in SIP checkout response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Bug ID: 28730 Summary: Add option to format AH field (due date) in SIP checkout response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org According to SIP2 spec on due date/AH: This date field is not necessarily formatted with the ANSI standard X3.30 for date and X3.43 for time. Since it is a variable-length field the ACS can send this date field in any format it wishes. Some machines pass this directly to the checkout receipt, we should be able to format as a due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123012&action=edit Bug 28730: Add option to format AH field (due date) in SIP checkout response This patch adds a new option to sip accounts: format_due_date If set to 1 the AH field in checkouts will follow the dateFormat system preference and format as due dates (ignoring time portion if 23:59:59 or 11:59:59) To test: 1 - checkout an item via SIP: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 3999900000001 --patron enda -m checkout 2 - Note the AH field is like "YYYYMMDD HHMMSS" 3 - Apply patch 4 - repeat SIP checkout - nothing has changed 5 - edit SIPConfig.xml and add format_due_date="1" to 'term1' account: <login id="term1" password="term1" delimiter="|" error-detect="enabled" institution="CPL" encoding="ascii" checked_in_ok="1" format_due_date="1"/> 6 - restart all 7 - repeat the SIP checkout 8 - AH field now matches dateFormat system preference 9 - Change your dateFormat preference 10 - repeat the SIP checkout 11 - AH matches new format Note: If you cannot renew and don't get an AH just check the item back in: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 3999900000001 --patron enda -m checkin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123012|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 124062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124062&action=edit Bug 28730: Add option to format AH field (due date) in SIP checkout response This patch adds a new option to sip accounts: format_due_date If set to 1 the AH field in checkouts will follow the dateFormat system preference and format as due dates (ignoring time portion if 23:59:59 or 11:59:59) To test: 1 - checkout an item via SIP: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 3999900000001 --patron enda -m checkout 2 - Note the AH field is like "YYYYMMDD HHMMSS" 3 - Apply patch 4 - repeat SIP checkout - nothing has changed 5 - edit SIPConfig.xml and add format_due_date="1" to 'term1' account: <login id="term1" password="term1" delimiter="|" error-detect="enabled" institution="CPL" encoding="ascii" checked_in_ok="1" format_due_date="1"/> 6 - restart all 7 - repeat the SIP checkout 8 - AH field now matches dateFormat system preference 9 - Change your dateFormat preference 10 - repeat the SIP checkout 11 - AH matches new format Note: If you cannot renew and don't get an AH just check the item back in: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 3999900000001 --patron enda -m checkin Signed-off-by: Winfred Thompkins <Winfred.thompkins@cedarhilltx.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124062|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125155&action=edit Bug 28730: Add option to format AH field (due date) in SIP checkout response This patch adds a new option to sip accounts: format_due_date If set to 1 the AH field in checkouts will follow the dateFormat system preference and format as due dates (ignoring time portion if 23:59:59 or 11:59:59) To test: 1 - checkout an item via SIP: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 3999900000001 --patron enda -m checkout 2 - Note the AH field is like "YYYYMMDD HHMMSS" 3 - Apply patch 4 - repeat SIP checkout - nothing has changed 5 - edit SIPConfig.xml and add format_due_date="1" to 'term1' account: <login id="term1" password="term1" delimiter="|" error-detect="enabled" institution="CPL" encoding="ascii" checked_in_ok="1" format_due_date="1"/> 6 - restart all 7 - repeat the SIP checkout 8 - AH field now matches dateFormat system preference 9 - Change your dateFormat preference 10 - repeat the SIP checkout 11 - AH matches new format Note: If you cannot renew and don't get an AH just check the item back in: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 3999900000001 --patron enda -m checkin Signed-off-by: Winfred Thompkins <Winfred.thompkins@cedarhilltx.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125156&action=edit Bug 28730: (QA follow-up) Add new option to example configs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions.. I added a follow-up to add the config option to the example configs (disabled by default). Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31552 [Bug 31552] SIP2 option format_due_date not honored for AH field in item information response -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org