[Bug 20616] New: Using "Edit serials" with no issues selected gives an ugly error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Bug ID: 20616 Summary: Using "Edit serials" with no issues selected gives an ugly error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com To test: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' There will be an internal server error: Use of uninitialized value $serstatus in split at /home/vagrant/kohaclone/serials/serials-edit.pl line 100. Can't call method "title" on an undefined value at /home/vagrant/kohaclone/serials/serials-edit.pl line 423. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74766&action=edit Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74766|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74768&action=edit Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Warning popup is better than an error page :) Thank you Cait ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It was Jonathan's work :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74768|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74772&action=edit Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74773&action=edit Bug 20616: (QA follow-up) Make alert translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Katrin Fischer from comment #4)
It was Jonathan's work :)
oups... Thank you Cait for pointing this issue, and Jonathan for solving it ! You're a great team. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org