[Bug 14047] New: Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Bug ID: 14047 Summary: Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: z.tajoli@cineca.it QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When you insert/modify a z39.50 server to use it in derivate cataloguing you can insert 'rank': [it] lets you enter where in the list you'd like this target to appear. If this is left blank the targets will be in alphabetical order. If you use authority servers it is OK. If you use bibliographic servers it doesn't work Now z39.50 bibliographic servers are sorted by id (insert order). This is because now we use DBIx in cataloguing/z3950_search.pl without an 'order_by'. The patch inserts 'order_by' instruction To test it: 1)Insert 3-4 z39.50 biblio servers and insert different values into 'rank' fields. 2)See the if you change 'rank', the order doesn't change 3)Apply the patch 4)See that now order is based on 'rank' and 'servername' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #1 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 38345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38345&action=edit Patch for sorting z39.50 servers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Zeno, same code is used in cataloguing/z3950_search.pl, you need to copy/paste your change. (That's exactly why I did not want to see DBIx::Class queries in pl files...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- I meant acqui/z3950_search.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #4 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 39214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39214&action=edit Patch for sorting z39.50 servers IN acq The patch is for acqui/z3950_search.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #5 from Zeno Tajoli <z.tajoli@cineca.it> --- To fix the bug you must applay the two patch. To test the second patch you need to use z39.50 inside an order into ACQ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38345|0 |1 is obsolete| | Attachment #39214|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39286&action=edit Bug 14047: Order z39.50 biblioservers in cataloguing Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39287&action=edit Bug 14047: Sort z39.50 servers in Acquisition Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39288&action=edit Bug 14047: [QA Follow-up] Move result_class back into attributes No need to put this into a separate call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note that we strictly speaking do not need the hashref inflator here, because TT understands hash.column as well as object.property. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39286|0 |1 is obsolete| | Attachment #39287|0 |1 is obsolete| | Attachment #39288|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39412&action=edit Bug 14047: Order z39.50 biblioservers in cataloguing Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 14047: Sort z39.50 servers in Acquisition Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 14047: [QA Follow-up] Move result_class back into attributes No need to put this into a separate call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note that we strictly speaking do not need the hashref inflator here, because TT understands hash.column as well as object.property. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- To gain readability, I squashed the 3 patches. Marcel I hope you don't mind and you are fine with that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org