[Bug 19729] New: Lists pages in OPAC are missing an HTML link element in last breadcrumb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Bug ID: 19729 Summary: Lists pages in OPAC are missing an HTML link element in last breadcrumb Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: simon.pouchol@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 --- Comment #1 from Simon Pouchol <simon.pouchol@biblibre.com> --- Created attachment 69439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69439&action=edit Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages. Test plan: 1-Go to /cgi-bin/koha/opac-shelves.pl 2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page) 3-Apply patch 4-Reload page, and notice there are now links, pointing to current page (#) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |simon.pouchol@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69439|0 |1 is obsolete| | --- Comment #2 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 69456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69456&action=edit Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages. Test plan: 1-Go to /cgi-bin/koha/opac-shelves.pl 2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page) 3-Apply patch 4-Reload page, and notice there are now links, pointing to current page (#) Signed-off-by: Dominic Pichette <dominic@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dominic.pichette@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69456|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70061&action=edit Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages. Test plan: 1-Go to /cgi-bin/koha/opac-shelves.pl 2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page) 3-Apply patch 4-Reload page, and notice there are now links, pointing to current page (#) Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- on href="#" we need to call preventDefault() or the scrollback will hit the top of the page. Apparently other pages have the same problem. Owen, do we need to take care of that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- To be perfectly honest I'm not sure why the last breadcrumb was ever a link. How is it useful to make it a dummy link? That seems very confusing. I don't know why 2013 me did that. I would prefer to remove all the links, and perhaps wrap the inactive last breadcrumb in a <span> with a consistent class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like Owen's suggestion, it makes sense to me. Should we move this onto a bug to change this globally? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we resolved this when re-working the breadcrumbs fro accessibility. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org